GithubHelp home page GithubHelp logo

Comments (4)

MurhafSousli avatar MurhafSousli commented on May 28, 2024 1

@adamdoyle track this here #56

from ngx-highlightjs.

MurhafSousli avatar MurhafSousli commented on May 28, 2024

I guess it is related to the issue you pointed out, did you try to load them in index.html instead?

from ngx-highlightjs.

tommyc38 avatar tommyc38 commented on May 28, 2024

@MurhafSousli I fixed it by adding github.css and highlight.pack.js into angular.json (app styles and scripts arrays)

from ngx-highlightjs.

adamdoyle avatar adamdoyle commented on May 28, 2024

@tommyc38 I know this is old, but did adding github.css to your styles array in angular.json actually remove the error from the console, or did it only fix the style? For me, it's only fixing the style, and (ideally) I'd like to get rid of the error as well.

My understanding is that with this approach the browser attempts to load the style from two places: (1) Angular CLI is bundling everything from the styles array in angular.json into styles.js, and (2) highlight.service.ts:_themeLoader() is dynamically inserting a <link> element at runtime to pull the styles from ${this.options.path}/styles/github.css.

The browser succeeds at loading the style with method (1), but fails for method (2). Since one of the two methods succeeded, the page renders correctly, but the extraneous failed <link> results in a console error.

@MurhafSousli To your knowledge, is there a mechanism in place for configuring ngx-highlightjs to not add the <link> tag and assume the consumer of the library is providing the styles on his or her own?

I tried HighlightModule.forRoot({path: '#'}), resulting in <link rel="stylesheet" type="text/css" href="#/styles/github.css">, which technically appeared to work (suppressed error messages and rendered the styles on-screen correctly), but probably isn't optimal as it leaves behind a dummy <link> element and probably leaves something similar for the Javascript.

from ngx-highlightjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.