GithubHelp home page GithubHelp logo

Comments (5)

mweibel avatar mweibel commented on May 11, 2024 1

Ok, I see. Please open a PR with your proposed change and I'll gladly review it.

from connect-session-sequelize.

mweibel avatar mweibel commented on May 11, 2024

That sounds reasonable. However: I had the same issue recently with the tests in this very module:
cbaa4b0

How about you'd also just give an expiration interval of -1 when in the tests?

from connect-session-sequelize.

glebec avatar glebec commented on May 11, 2024

@mweibel, you could definitely do so, but then you are modifying the session store behavior for testing, rather than cleaning up resources after testing. On principle I prefer to keep tested code as close to production as is reasonable.

from connect-session-sequelize.

mweibel avatar mweibel commented on May 11, 2024

True. Though my question is what would you like to change? stopExpiringSession is already a public API. I'd welcome a PR.

from connect-session-sequelize.

glebec avatar glebec commented on May 11, 2024

It’s publicly exposed but not documented, making it arguably an implementation detail rather than an API method. Explicitly documenting it as a feature would both aid in discovery and also signal that it is ok to use and will be tracked in SEMVER.

from connect-session-sequelize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.