Add onClick with popup about sharingbuttons.io

[mxstbr]

That'd be a fallback though, if JS is disabled, right?

[peter-mouland]

lol - ah yeah, was thinking of js event rather than html! i'll go back to sleep! 😴

[olets]

Nice idea. In another project I already have window dimensions for some of the pop-ups we'll need. I'll add those in the next couple days, and then we can see what services are still missing

[mxstbr]

Sounds awesome, let's make this optional though! (toggle on/off)

[equinusocio]

Obviously target="_blank" is useless when there is the onClick attribute. 👍

[peter-mouland]

*or if the user clicks before the js had fully initialised i.e. slow connection/device

[equinusocio]

@peter-mouland It's a native js string, not jQuery :P. I think the onClick can be launched before the html appear 😂

[mxstbr]

What is "Hacktoberfest" tag? This is not hack.

See here.

[equinusocio]

Ok, so we have to wait 1 year for this enhancement? .... .. .

[mxstbr]

No, just submit a PR if you want to 😊

[sparr]

Why onClick instead of just target?