How to deal with uncloneable objects ? about deepcopy

[jkuchar]

Isn’t this same problem as #24 where there was problems with array members?

BTW isn’t it better to use type matcher instead of property matcher?

[Jan0707]

I don't think it's the same problem.

Am I not using a type matcher here ?
$deepCopy->addFilter(new SetNullFilter(), new PropertyTypeMatcher('MongoId'));

[jkuchar]

Interfaces Filter and TypeFilter are different. Filter is executed only on object properties; type filter checks also arrays contained in properties.

[Jan0707]

Indeed, but if I were to use a TypFilter like this:

interface TypeFilter
{
    /**
     * Apply the filter to the object.
     * @param mixed $element
     */
    public function apply($element);
}

The interface clearly states that the apply function is only called with the $element. But as you can see in the example code above, I also need the property name to decide what to do.

[jkuchar]

Yep, that is true. In property filter you have to manually iterate over arrays. That’s it.

[mnapoli]

Via debugging I found out that my filter is being executed, but apparently not in every case.

Are you able to see what those cases are? @jkuchar suggested they might be in objects that are in arrays, could be it…

Also there's an option to skip uncloneable objects: https://github.com/myclabs/DeepCopy/blob/master/src/DeepCopy/DeepCopy.php#L42 It might be what you are looking for?

[Jan0707]

Also there's an option to skip uncloneable objects

I'll have a look into it, but I do not think that simply not copying the objects and then posting to the original object, will work well with doctrine's unit of work.

Array might also be an possibility, I'll check that.

[jkuchar]

Then please try to propose a solution and post PR. When something does not work, the best way of fixing it is to create test and describe exctly intended behaviour there.

[Jan0707]

I am more than glad to implement a solution, I just wanted to check back with you guys, what the best approach would be, since I would like this feature to be merged back into the repo. So I kind of need your blessing ;)

Anyway, I tried to come up with a test case that demonstrates what I am looking for:

https://gist.github.com/Jan0707/9aeb502cd72e8dbdb890

[jkuchar]

It looks like MongoId is not clone-able. So you need to do two things:

1. implement filter to clone all instances of MongoId manually (->addTypeFilter)
2. Filter those instances you do not want to clone (->addFilter)

[Jan0707]

Thanks a bunch ! I updated the gist: https://gist.github.com/Jan0707/9aeb502cd72e8dbdb890

Guess the problem was that I was not aware that you could combine TypeFilter and ordinary Filters, I assumed DeepCopy would only execute the first one it finds suitable.