Notice: Undefined property: DateTime::$date about deepcopy

[tchiotludo]

The same bug here in php 7.0.7 cloning a Carbon object with this error :

Unknown getter 'date'
InvalidArgumentException code(0) in /vendor/nesbot/carbon/src/Carbon/Carbon.php line 527

at Carbon\Carbon->__get ('date') in Carbon.php line 527
at getValue (Object(Cawa\Date\DateTime)) in DeepCopy.php line 179

In case it may help you, I've a similar bug on datetime related to this thread :
http://news.php.net/php.internals/93826%20view%20original
Datetime is not accessible via reflection and it seems to be "normal"

In my case, for a recursive serialize of object, I used a ugly hack that handle datetime like undeclared public properties : https://github.com/cawaphp/cawa/blob/master/src/Serializer/Serializer.php#L128
and unserialize is also hacky for internal class : https://github.com/cawaphp/cawa/blob/master/src/Serializer/Serializer.php#L205

@mnapoli : for simple cloning, take care about extends class that will contains reference like DatePeriod for example

[mnapoli]

That's interesting! The best solution I think would be to not try to iterate on internal classes properties: objects like DateTime or stdClass should simply be cloned as-is I guess (because they usually don't have references to other objects so we can treat them as values).

[arthurkhusnullin]

Also Notice: Undefined property: DateTimeZone::$timezone_type

[peternijssen]

@mnapoli I added a check for internal objects. (see pull request #42) The problem is now that multiple tests are failing because the tests are depending on the StdClass object. I am not sure if we should exclude that class from cloning or not.

The only thing I can think off right now is to let StdClass be cloned or change the tests to actually have a self defined object.

[ladamalina]

@theofidry Please, merge your fix asap. Our Jenkins unit tests are stuck because of DeepCopy bug with DateTime::$date 🙇 🙇

[theofidry]

@ladamalina I'm not a maintainer and I don't have write access either, so the maintainers need to review my fix first and decide to merge it or not :)

[mnapoli]

I'm very sorry for the delay everyone. I've merged #43 and tagged 1.5.2, please check out if all works fine for you now.

Thanks @theofidry and others who contributed and review the fix.

[theofidry]

You're welcome, works like a charm on my end ;)