Use a factory for DeepCopy about deepcopy

[mnapoli]

A factory is only responsible for creating an object, not caching it -> that would make the whole thing a singleton/static accessor (which is of course not a good idea).

Today dealing with the instance of the service is the responsibility of the user, just like with any other package AFAIK (e.g. Symfony's translator, Twig's instance, etc. etc.). When using a DI container it's not an issue at all (you configure DeepCopy once, it gets created once and injected everywhere needed).

[theofidry]

Giving an alternative to DI is good as well. To take the example of Symfony components, you do have PropertyAccess which a factory implementing the singleton pattern.

I'm actually more concerned about the cache system of DeepCopy: it uses spl_object_hash which can be given to two very different objects if the first one has been unset. If you create a new instance you reduce the chances to have this issue, but I have no idea how much you raise the likelihood of having this issue by having a single instance.

[mnapoli]

The hashmap is reset each time copy() is called (https://github.com/myclabs/DeepCopy/blob/master/src/DeepCopy/DeepCopy.php#L55). Yes it's not the cleanest solution ever ;) but well it works

[theofidry]

Oh I missed that. Hm ok so there is no real point for a factory then...