GithubHelp home page GithubHelp logo

Comments (3)

theofidry avatar theofidry commented on July 17, 2024

@hackel I don't think DeepCopy should do anything here.

To me (@mnapoli may have a different vision and correct me), there is two use cases for DeepCopy:

  • Use to ensure real deep cloning, that might be necessary in libraries like PHPUnit or weird cases where you might have circular references
  • A more common userland deep cloning which should not be much more than calling a regular clone, check recursively for arrays or simple do nothing on scalar values

From the error it looks like BSON objects, or at least ObjectID prevents any clone call. There might be a reason to it, but I don't think DeepCopy should implement custom ways of cloning. If you want to do that, I would rather recommend to extend/decorate it instead.

from deepcopy.

mnapoli avatar mnapoli commented on July 17, 2024

👍 to me we shouldn't do anything specific here, you can use filters and matchers to clone ObjectID properly.

from deepcopy.

hackel avatar hackel commented on July 17, 2024

Yes, that makes more sense, thanks.

from deepcopy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.