Comments (4)
Yeah, that change would be beneficial. The model two (which is x86) boots off of a SD card or USB flash drive, so this was added as an optimization for that platform.
It may be better to leave it installed and just disable log2ram if it's not on an SD card during startup or add an option to enable/disable on the settings page manually. The images are typically made using log2ram while they are on an USB drive, so any detection done during setup_device.sh may not represent the final drive the device is actually using. There's also one other install location in mynode_post_upgrade.sh.
from mynode.
The model two (which is x86) boots off of a SD card or USB flash drive, so this was added as an optimization for that platform.
Ah okay that makes sense.
It may be better to leave it installed and just disable log2ram if it's not on an SD card during startup or add an option to enable/disable on the settings page manually.
Yeah that makes sense. For the time being I'll do some work to see why it's failing on Debian 12 and either fix it or create an option to disable starting the service.
The images are typically made using log2ram while they are on an USB drive, so any detection done during setup_device.sh may not represent the final drive the device is actually using.
Okay. I'm just using the setup_device.sh script on a Debian 12 VM so I'm not sure how that merges with the building the image logic. Any suggestions and how to deal with this?
There's also one other install location in mynode_post_upgrade.sh.
I see there is a lot of duplicated code in mynode_post_upgrade.sh
and setup_device.sh
, are you okay if I create a libs
directory and put some simple bash scripts in there with common functions that we can import (source) in both of the scripts? This would allow us to write the code once and just use it when we need it in multiple places.
from mynode.
For the time being I'll do some work to see why it's failing on Debian 12 and either fix it or create an option to disable starting the service.
I was able to fix the issue with Debian 12, PR is her: #869
I still think it's good to do a few things:
- Detect if the system is on an Sdcard, USB, etc and install log2ram by default.
- Have an option in the mynode webui to enable/disable log2ram.
- Have a libs directory for common bash function that can just be imported into various scripts.
Let me know what you think about the above things, and the questions from my previous comment and I'd be happy to support PRs for all of this.
Thanks for the app, MyNode has been super helpful for me, I just switched to it from Umbrel.
from mynode.
Glad to hear you've been liking it!
Okay. I'm just using the setup_device.sh script on a Debian 12 VM so I'm not sure how that merges with the building the image logic. Any suggestions and how to deal with this?
OK, I see how you've been using setup_device. That's basically the use case, when running it on a base debian distro, it will add and install and the default apps and software. Your PR change was good.
I see there is a lot of duplicated code in mynode_post_upgrade.sh and setup_device.sh, are you okay if I create a libs directory and put some simple bash scripts in there with common functions that we can import (source) in both of the scripts? This would allow us to write the code once and just use it when we need it in multiple places.
I see there is a lot of duplicated code in mynode_post_upgrade.sh and setup_device.sh
There is a lot of duplication between the two, but they have different use cases and at this point, that code almost never needs to change. I'd prefer not to change it up at this point. A lot duplicate code that does change was pulled out into a separate script and all future apps use the SDK approach so they go into their own locations without needing to be in either setup_device.sh
or mynode_post_upgrade.sh
. You can see some of that in mynode_app_versions.sh
and rootfs/standard/usr/share/mynode_apps/
.
I like the second suggested option the most. The first could be nice, but I worry it could be error-prone. I'm not sure how to consistently detect the type of hardware.
from mynode.
Related Issues (20)
- fresh install on raspberry pi 4; some apps stuck in "installing ..." forever HOT 3
- Electrum Wallet will not connect. HOT 1
- LND Error - The LND service is not running properly. HOT 1
- Docker error="unauthorized: authentication required" HOT 10
- security: implement LNbits update to 0.12.x HOT 1
- i2pd is running even not enabled as a bitcoin protocol HOT 5
- Support for UPS power shutdown HOT 2
- Public IP shown in Status page would be useful HOT 1
- Bug fix
- allow PCIe NVMe on Raspberry Pi 5 HOT 5
- When I debug a transaction with both a P2TR scriptpath and a P2TR keypath input, I always get an error:
- Problem on Raspi5 initial login HOT 2
- Change the size in MyNode . OVA OS Disk HOT 3
- Broken links with tailnet on
- Migration to PC mynode HOT 2
- Cannot connect to Alby with LND - ERR_UNSAFE_PORT 10080 HOT 1
- Color Shell
- HANGS - Setting up containerd.io (1.7.19-1) ... HOT 2
- 403 - Forbidden when installing under debian with the script
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mynode.