Comments (12)
@renshenhe Thank you for your feedback, I suggest that now do not use Dialog
, need to continue to improve this component, if I set the
padding
properties can be controlled, the effect should be better, I would like to hear your voice.
from react-uwp.
@renshenhe This project will support css-in-js
and inline-style
both styles in the near future, some of the bugs that are not very serious will resolved after the branch merge, because it will change most of the code.
from react-uwp.
@myxvisual Sorry I could not respond sooner, been busy.
The ContentDialog
would work fine as a temporary Dialog
component if content
prop accepted reactNode
instead of string or access to it's attributes/styles. I am unsure whether there was intention in making it have a minimum height or accepts a string only so I cannot comment on it's design.
Personally I would prefer a Dialog
component with an empty body that is controlled visibly through props and onBlur
but I have only glanced at the source code of ContentDialog
so my assessment could be lacking.
I am looking forward to the reimplementation using css-in-js
as inline-style
leaves much wanting and a messy browser inspections.
So far the library has been pleasant to work with, though I have many personal preferences when it comes to the current design of the library:
-
Components are not built with respective html elements e.g.
CheckBox
does not useinput
therefore it does not havetarget.value
making it's use a little awkward sometimes. -
Preference of passing
Event
object rather thanvalue
orchecked
for majority of component event handlers. i.echecked => onChangeValue(checked)
is less preferable thanevent => onChange(event)
-
Animations(speed control & transition type):
Tabs
component for example could have option for animation speed control as animation style.Tabs
current content animation is quite uncomfortable for me seeing it slide right and left every transition instead of sliding relevant to their position in the tabs order. e.g. Sibling to Sibling
No need to take my suggestions, the library is great, but these are just things I found lacking when rewriting my app with react-uwp
.
Thanks for listening!
from react-uwp.
@renshenhe Thanks for useful advice.
from react-uwp.
@renshenhe i already update ContentDialog
to Docs, you can try some new API to build your custom UI, the Tabs
is more powerfull then before.
from react-uwp.
@myxvisual What changed exactly with ContentDialog
? I couldn't find anything significant in the recent commits. The issue I have with ContentDialog
is that content
property has a minimum height which makes contentNode
have a large gap above it. Any reason why content
can't just accept a react node?
from react-uwp.
@renshenhe hi, now ContentDialog
is support custom padding
props, it could help you solve your requirement?
The ContentDialog Docs
from react-uwp.
@myxvisual It was never the padding issue, it was the min-height: 160px
on content-dialog-titleWrapper
that meant if contentNode
would always have a 160px top gap if no values were passed to title
or content
. My requirements would simply be removing title
and content
and just having contentNode
so the component would be more customizable.
If ContentDialog
was designed for a specific purpose than that's fine but since the library currently does not have a stand alone Dialog
component which leaves a lot to be desired.
from react-uwp.
@renshenhe sure, now i know what you want, i will continue to develop the Dialog
component.
from react-uwp.
@renshenhe hi, the Dialog is available at v1.1.2
.
from react-uwp.
@renshenhe If this update has solves your needs, you can close this issue, thanks.
from react-uwp.
@myxvisual thanks for the implementation, really active commitment! I haven't gotten a chance to dive into the new Dialog component as much of my current usage is ContentDialog
and removing min-heigh
from title-wrapper
at the moment.
I have taken a slight glance at it and seems far more customizable so it looks good!
from react-uwp.
Related Issues (20)
- ???
- [DOCS]Scrolling laggy on mobile
- Keep getting exception 'document is not defined'
- Is this repo still being maintained?
- Any table component ?
- Toast component does not work
- It seems that there are some little bugs about theme.
- The tooltip component may cause some unhappiness
- Got a conflict error with react@>=17.0.0 while installing
- StyleManager always set style in document.head HOT 2
- commandbar render failed HOT 6
- desktopBackgroundImage render issue in electron two package structure HOT 1
- Where is ReactUWP.ThemeType definition HOT 3
- SplitViewCommand may lose attributes in create
- onChangeTime callback on TimePicker does not work
- How to show Toast programmatically?
- About source code of icon component
- Uncaught TypeError: Cannot convert undefined or null to object - When trying to change theme using local state(Toggling between 'dark' and 'light' ).
- needGenerateAcrylic={false} on SSR
- 组件不太流畅,有点卡顿
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-uwp.