GithubHelp home page GithubHelp logo

Comments (4)

mzakizadeh avatar mzakizadeh commented on July 2, 2024

First of all, thanks for sharing your suggestions. I appreciate you for reading the code and trying to make it better.

And here is my thoughts on your suggestions:

  1. The reason why I didn't use MainAxisAlignment.center in first place is because I want icons stays fix when opening animation is firing. If you look at Test 2 tab in these examples you'll see the effect. And that's why I calculate margins manually for each tab.

MainAxisAlignment.start:
with

MainAxisAlignment.center:
without

  1. I didn't quite get what you mean. Can you explain more about how I can use devicePixelRatio for labelFlex?

from shifting_tabbar.

PhilipChng avatar PhilipChng commented on July 2, 2024

Alright, I get it for the first point.
For the 2nd point, the default labelFlex is now 1.0. Perhaps you can make it by default using MediaQuery.of(context).devicePixelRatio. It looks better across different screen size in my opinion.

from shifting_tabbar.

PhilipChng avatar PhilipChng commented on July 2, 2024

Nevermind, I found 1.0 works fine. Thanks!

from shifting_tabbar.

mzakizadeh avatar mzakizadeh commented on July 2, 2024

The thing is, in my opinion, there is no fixed value for labelFlex. There are some tricks that you can do to get a better look. First thing is to try to choose words for tab titles that have same length and then you can tune labelFlex value to works fine with them.

from shifting_tabbar.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.