GithubHelp home page GithubHelp logo

Comments (10)

benjamingiraud avatar benjamingiraud commented on June 9, 2024 1

#4 fixed the problem for me

from antd-theme-webpack-plugin.

mzohaibqc avatar mzohaibqc commented on June 9, 2024

@romangutkin No, this is beacuase there is no such variable @menu-dark-arrow-color0f6. This some bug which is adding this extra 0f6 at the end of @menu-dark-arrow-color variable.

Is this .ant-tag-pink your custom css class?

from antd-theme-webpack-plugin.

romangutkin avatar romangutkin commented on June 9, 2024

@mzohaibqc Thanks for replying! I think that once i defined the @menu-dark-arrow-color as a dynamic less variable in my webpack config (using antd-theme-webpack-plugin) then it cant be parsed when the color.less file is being created. .ant-tag-pink is not my custom css class, i believe it is being generated by antd.

from antd-theme-webpack-plugin.

benjamingiraud avatar benjamingiraud commented on June 9, 2024

Same with "@btn-primary-color"

from antd-theme-webpack-plugin.

sli avatar sli commented on June 9, 2024

I'm having this issue with the same variable from #4 (@component-background), but I don't see a fix in that issue. I'm not using pure white or pure black anywhere, it's defined in variables.less, and it's listed in my rescripts config for use with react-app-rewire-antd-theme. The other variables I've configured are working, it's just that one that fails.

from antd-theme-webpack-plugin.

sli avatar sli commented on June 9, 2024

I figured out what's happening.

If any of your custom colors start with a SUBSET of an already-defined color, this bug will trigger. That means none of your custom colors can start with #000 or #fff because those are already in use. So the tip to make a minor change to get around it (like using #fffffe) does not fix the problem, as that color value also triggered the bug. Changing the color value to #efffff made the variable start working.

This bug does not trigger when using window.less.modifyVars to switch themes, only on the initial colors defined in variables.less.

This is a major limitation.

from antd-theme-webpack-plugin.

mzohaibqc avatar mzohaibqc commented on June 9, 2024

@romangutkin @sli @benjamingiraud Thanks for reporting this issue. I know it's too late but I hope it will help you or at least others to avoid this issue. I've fixed and published a new version of this plugin

[email protected]

Or if someone is using core script it is [email protected]

from antd-theme-webpack-plugin.

ygs-code avatar ygs-code commented on June 9, 2024

So I can't use windo.less.modifyvars () to dynamically update my custom styles.
Because static style
Wiki - the title {
Color: red;
}.

covers
The wiki - the title {
Color: @ wiki - the title - color;
}
Dynamic style,

This is the antd-theme-webpack-plugin bug

from antd-theme-webpack-plugin.

ygs-code avatar ygs-code commented on June 9, 2024

So I can't use windo.less.modifyvars () to dynamically update my custom styles.
Because static style
Wiki - the title {
Color: red;
}.

covers
The wiki - the title {
Color: @ wiki - the title - color;
}
Dynamic style,

This is the antd-theme-webpack-plugin bug

from antd-theme-webpack-plugin.

mzohaibqc avatar mzohaibqc commented on June 9, 2024

@qq281113270 I'll be happy to help you but first you need to explain it well, what's the bug. Read your own comment and see if it makes sense or not. e.g.

The wiki - the title {
Color: @ wiki - the title - color;
}

Is neither a valid css nor a text that conveys something.

So kindly explain bit more.

As for as custom variable is concerned, it works, see the example. https://github.com/mzohaibqc/antd-theme-webpack-plugin/blob/master/examples/create-react-app/src/App.js

@secondary-color is a custom variable and not part of antd variables.

from antd-theme-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.