Not all protos files are required about poke-api

[nabeelamjad]

Which request(s) is this needed for? The way protobufs works is that the request needs to have the pokemon_id linked to that Protobuf, though it might be confusing because pokemon_id doesn't always refer to the Pokedex number.

Take for example ReleasePokemon, pokemon_id refers to your unique pokemon id (obtained via get_inventory, example here).

However if you look at EncounterTutorialComplete it refers to the Pokedex entry directly (working as intended) as it does not refer to your unique Pokemon.

[nicolas-besnard]

For instance with get_inventory, you will get a JSON with the following hash for each Pokemon in your inventory

 {:id=>17999104379928447950, :pokemon_id=>:ONIX

What I want to do, is getting the Pokemon's Pokedex ID (instead of :ONIX).

[nabeelamjad]

Aha, this actually seems intended by the protobufs (https://github.com/nabeelamjad/poke-api/blob/master/lib/poke-api/POGOProtos/Data/PokemonData.rb#L12). It maps the given number to a name by default, you may have to use custom conversion to change it back (I can provide a sample code on how to do that if you wish).

[nicolas-besnard]

The mapping already exists with the protobufs, It seems strange to have to
redefine my own enum.
On Thu, 28 Jul 2016 at 11:03, nabeelamjad [email protected] wrote:

Aha, this actually seems intended by the protobufs (
https://github.com/nabeelamjad/poke-api/blob/master/lib/poke-api/POGOProtos/Data/PokemonData.rb#L12).
It maps it to a name by default, you may have to use custom conversion to
change it back.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNAZkX7d7c_ofmLsuhwd8-7mrj9AfR3ks5qaNLFgaJpZM4JW1cG
.

Nicolas

[nabeelamjad]

Here is how you could use it, unfortunately unless you want to change the Protobufs or fork it and remove the reference to PokemonID this is the only workaround I know of.

require 'poke-api'
require 'poke-api/POGOProtos/Enums/PokemonId' # You don't have to load this file after your response as it will be loaded.

def fetch_pokemon_id(name)
  POGOProtos::Enums::PokemonId.const_get(name)
end

fetch_pokemon_id(:ONIX)
 => 95

To give you an insight what's happening internally, the protobufs are returning the ID 95 but because we (the protobufs for pokego) have an enum mapped to the ID it will map that like so:

POGOProtos::Enums::PokemonId.lookup(95)
 => :ONIX

Which then returns :ONIX instead of your ID because of the enum mapping.

[nicolas-besnard]

Indeed, your solution works :)