Replace println() for info() about reactive

[nafg]

Hi, thanks for opening a ticket --- I had planned on having a ticket for this.
The question is, is there any reason to consider anything besides Lift's logging system?
(Whoever reads this ticket, you're invited to put in your two cents. :) )

[fmpwizard]

I would be happy just using Lift's logging system, as it allows you to use any logger you like (afaik). One reason to use a different logging system could be if people could use reactive web without Lift.

[nafg]

First of all, reactive-core does not only exist for reactive-web.
That said, it's not really such an issue. It simply means that reactive-core would have to have a dependency on lift-common.
However, I would prefer to get a few more opinions before making a decision that will be harder to change later.
More importantly, I think that reactive needs a very fine-grained way to enable/disable/filter logging, because there's a ton different kinds of information that could be very important at times for debugging, but too much information drowns out the important part. For instance, you may want a lot of information about a particular instance, or watch the effects of a single particular event. I'm not sure what the right way to implement that is, and if there's anything that would make it easier than Lift's logging. (Again, I think it's very likely that Lift's is the best, but I want to hear opinions from as many different people as possible.)

[fmpwizard]

Do you think it makes sense to email the Scala and Lift mailing lists to get feedback? I just happened to visit the bugs section on github the other day, but normally I only check the lift mailing list.

As for logging details, it would be great to have that level of detail, as long as it was easy to enable/disable.

[fmpwizard]

Any news on this bug? Thanks !

[nafg]

The problem with Lift's logging is that there needs to be a way to set the
log level per instance.
I plan to ask on the Lift list if it's possible to add such a feature,
unless you know of an alternative.

On Thu, Jun 9, 2011 at 11:18 PM, fmpwizard <
[email protected]>wrote:

Any news on this bug? Thanks !

Reply to this email directly or view it on GitHub:
#4 (comment)

[nafg]

I have a fix for this locally. It uses a completely new semantic logging system: There is a global singleton that fires events that are logged from an event stream. Reactive sends logging events instead of println. You can write
Logger.all =>> println
or
Logger.errors =>> myLogger.error
etc.

[fmpwizard]

Great!! So I control it from boot?

Sent from my cell
Diego Medina
On Jun 21, 2011 4:58 PM, "nafg" <
[email protected]>
wrote:

I have a fix for this locally. It uses a completely new semantic logging
system: There is a global singleton that fires events that are logged from
an event stream. Reactive sends logging events instead of println. You can
write
Logger.all =>> println
or
Logger.errors =>> myLogger.error
etc.

Reply to this email directly or view it on GitHub:
#4 (comment)

[nafg]

That would be the typical place, I suppose.

On Tue, Jun 21, 2011 at 5:23 PM, fmpwizard <
[email protected]>wrote:

Great!! So I control it from boot?

Sent from my cell
Diego Medina
On Jun 21, 2011 4:58 PM, "nafg" <
[email protected]>
wrote:

I have a fix for this locally. It uses a completely new semantic logging
system: There is a global singleton that fires events that are logged from
an event stream. Reactive sends logging events instead of println. You can
write
Logger.all =>> println
or
Logger.errors =>> myLogger.error
etc.

Reply to this email directly or view it on GitHub:
#4 (comment)

Reply to this email directly or view it on GitHub:
#4 (comment)

[fmpwizard]

Hm,

I just did a sbt update, to get the latest, but adding

reactive.Logger.errors =>> println to boot gives me a compiler error:

value Logger is not a member of package reactive
[error] reactive.Logger.errors =>> println

Do you think maybe the repo does not have the latest code?

Thanks

[nafg]

Not maybe, definitely. :)
I actually just pushed it to github not long ago, but I also upgraded to sbt
0.10 and something is going wrong on Cloudbees' Jenkins. I emailed the sbt
list, but in the meanwhile you would have to build it locally.

On Wed, Jun 22, 2011 at 11:14 PM, fmpwizard <
[email protected]>wrote:

Hm,

I just did a sbt update, to get the latest, but adding

reactive.Logger.errors =>> println to boot gives me a compiler error:

value Logger is not a member of package reactive
[error] reactive.Logger.errors =>> println

Do you think maybe the repo does not have the latest code?

Thanks

Reply to this email directly or view it on GitHub:
#4 (comment)