Comments (10)
I think we need @davidbarbrowatwork to review your requested change because I believe it was his changes to 1.5.8 that affected the code you are trying to fix. Can you try to find/nudge him to get him to review/approve your requested change?
from antisamy.
Hi @davidbarbrowatwork, I found the performance is down by almost 50% in the 1.5.8 antisamy version comapre to 1.5.7.
I have debugged the issue and raised a pull request for it on @davewichers repository.
Can you please review it once as it is urgent for me.
from antisamy.
Hi @davewichers , can you please try to connect to @davidbarbrowatwork to review this PR, as I couldn't get any response from.
from antisamy.
from antisamy.
Hi @davewichers, if you have twitter id of @davidbarbrowatwork can you please share.
Thanks
from antisamy.
I think it is @ dbarbrow.
from antisamy.
Hi @davewichers,
Is the master branch of this repo is 1.5.8? I found the pom.xml of master master branch have project version 1.5.8 and could not find any specific branch for 1.5.8.
from antisamy.
This is the 1.5.8 release: https://github.com/nahsra/antisamy/releases and I believe there is a checkin tag for that release.
I've created a 1.5.9 branch, so I suggest you make any suggested changes to that branch. Hopefully you can add test cases that show the slowdown you are talking about, but correct behavior otherwise. And then when we add your requested change we can see a significant performance improvement but the same correct functionality verified by the test case.
from antisamy.
Hi @davewichers, Change that i have made was present in the branches below 1.5.8.
For example
- In version 1.5.4: line number 131 of https://github.com/nahsra/antisamy/blob/1.5.4/src/main/java/org/owasp/validator/html/scan/AntiSamySAXScanner.java
- Version 1.5.5: line number 131 of https://github.com/nahsra/antisamy/blob/1.5.5/src/main/java/org/owasp/validator/html/scan/AntiSamySAXScanner.java
- Version 1.5.6: line number 131 of https://github.com/nahsra/antisamy/blob/1.5.6/src/main/java/org/owasp/validator/html/scan/AntiSamySAXScanner.java
- Version 1.5.7: line number 131 of https://github.com/nahsra/antisamy/blob/1.5.7/src/main/java/org/owasp/validator/html/scan/AntiSamySAXScanner.java
And I got an instruction to use 1.5.8 version of the Antisamy.So I request to please consider it for version 1.5.8.
Thanks
from antisamy.
The requested line has been added, and this fix was just released in version v1.5.9 of AntiSamy, along with a few dependency upgrades.
from antisamy.
Related Issues (20)
- Change in behavior between 1.6.4 and 1.6.5 for getErrorMessages HOT 7
- Commit details for CVE-2022-28366? HOT 4
- Remove all deprecated APIs/features in prep for 1.7.0 release HOT 1
- ASHTMLSerializer uses deprecated HTMLSerializer. Replace with TrAX.
- AntiSamy converting single quotes to double quotes for font-family which is causing issue while rendering HOT 6
- AntiSamy not detecting XSS for anchor tag HOT 10
- CssHandler test case failure on Windows HOT 5
- Incorrect 'Contributing' link on OWASP wiki page HOT 1
- Javadoc cleanup
- 2 enhancement HOT 2
- 1 enhancement with api HOT 2
- CVE-2022-24891 HOT 7
- Removing Xerces dependency? HOT 3
- Does Antisamy has support for custom css properties " --* " and css-function " var() " and how to define it in the antisamy policy file? HOT 10
- Enabled noopenerAndNoreferrerAnchors policy drops nofollow HOT 7
- Covering all cases of "rel" attribute in "anchor" tag is quite verbose HOT 3
- Investigate replacing Batik CSS HOT 1
- Dealing with Security Vulnerabilities CVE-2023-26119 HOT 13
- AntiSamy encodes unknown tags despite not being configured that way HOT 6
- GraalVM Support HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from antisamy.