GithubHelp home page GithubHelp logo

Comments (10)

clqian avatar clqian commented on July 24, 2024 1

hi @davewichers @spassarop yes the changes work for me. thank you so much!

from antisamy.

davewichers avatar davewichers commented on July 24, 2024

@spassarop - Can you answer this?

from antisamy.

spassarop avatar spassarop commented on July 24, 2024

Hi @clqian, DOM or SAX, any of them have the same issue with an LSEP character because the compiled Pattern for the regexp does not have the Pattern.DOTALL flag. Then, although you may want to match any character, it does not consider line separators.

If every compiled regexp has that flag on Policy parsing, it works. @davewichers do you think that would be ok? Change should be on 5 occurrences only in Policy class.

from antisamy.

davewichers avatar davewichers commented on July 24, 2024

I'm not qualified to comment on that. @nahsra - Arshan? What do you think?

from antisamy.

jdr023 avatar jdr023 commented on July 24, 2024

any updates on this?

from antisamy.

nahsra avatar nahsra commented on July 24, 2024

I agree with @clqian -- I think the character set being called literally "anything" should suggest that LSEP be allowed characters. We can't say for certain about how allowing LSEP would affect markup parsing in the browsers because they're essentially black boxes with unpredictable behavior at times, but I am comfortable with the change overall.

from antisamy.

spassarop avatar spassarop commented on July 24, 2024

Something I can add is that the LSEP char may not be included in the output. At least I tested it as a unicode char and I could not make it appear after the sacan :(

That change can be done tomorrow I think. It's really simple.

from antisamy.

davewichers avatar davewichers commented on July 24, 2024

Hey @clqia, @spassarop implemented a change to address this issue and I just merged it into the 1.6.0 branch. Can you review the change and test. And let us know if you think this fixes this issue properly? Can if you could do that tomorrow that would be great, as we are trying to get the 1.6.0 release out in the next few days. Thx

from antisamy.

davewichers avatar davewichers commented on July 24, 2024

OK. This issue will then be fixed in the 1.6.0 release, which should be coming out soon.

from antisamy.

davewichers avatar davewichers commented on July 24, 2024

This was addressed in commit 3f446c5 and AntiSamy v1.6.0 was released today with this included.

from antisamy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.