Comments (10)
hi @davewichers @spassarop yes the changes work for me. thank you so much!
from antisamy.
@spassarop - Can you answer this?
from antisamy.
Hi @clqian, DOM or SAX, any of them have the same issue with an LSEP character because the compiled Pattern for the regexp does not have the Pattern.DOTALL
flag. Then, although you may want to match any character, it does not consider line separators.
If every compiled regexp has that flag on Policy parsing, it works. @davewichers do you think that would be ok? Change should be on 5 occurrences only in Policy class.
from antisamy.
I'm not qualified to comment on that. @nahsra - Arshan? What do you think?
from antisamy.
any updates on this?
from antisamy.
I agree with @clqian -- I think the character set being called literally "anything" should suggest that LSEP be allowed characters. We can't say for certain about how allowing LSEP would affect markup parsing in the browsers because they're essentially black boxes with unpredictable behavior at times, but I am comfortable with the change overall.
from antisamy.
Something I can add is that the LSEP char may not be included in the output. At least I tested it as a unicode char and I could not make it appear after the sacan :(
That change can be done tomorrow I think. It's really simple.
from antisamy.
Hey @clqia, @spassarop implemented a change to address this issue and I just merged it into the 1.6.0 branch. Can you review the change and test. And let us know if you think this fixes this issue properly? Can if you could do that tomorrow that would be great, as we are trying to get the 1.6.0 release out in the next few days. Thx
from antisamy.
OK. This issue will then be fixed in the 1.6.0 release, which should be coming out soon.
from antisamy.
This was addressed in commit 3f446c5 and AntiSamy v1.6.0 was released today with this included.
from antisamy.
Related Issues (20)
- Improve Unit Test Coverage
- how to edit the antisamy.xml to support the css-style "-webkit-border-radius" or "-moz-border-radius" HOT 6
- require-closing-tags is not supported by antsamy.xsd HOT 5
- Change in behavior between 1.6.4 and 1.6.5 for getErrorMessages HOT 7
- Commit details for CVE-2022-28366? HOT 4
- Remove all deprecated APIs/features in prep for 1.7.0 release HOT 1
- ASHTMLSerializer uses deprecated HTMLSerializer. Replace with TrAX.
- AntiSamy converting single quotes to double quotes for font-family which is causing issue while rendering HOT 6
- AntiSamy not detecting XSS for anchor tag HOT 10
- CssHandler test case failure on Windows HOT 5
- Incorrect 'Contributing' link on OWASP wiki page HOT 1
- Javadoc cleanup
- 2 enhancement HOT 2
- 1 enhancement with api HOT 2
- CVE-2022-24891 HOT 7
- Removing Xerces dependency? HOT 3
- Does Antisamy has support for custom css properties " --* " and css-function " var() " and how to define it in the antisamy policy file? HOT 10
- Enabled noopenerAndNoreferrerAnchors policy drops nofollow HOT 7
- Covering all cases of "rel" attribute in "anchor" tag is quite verbose HOT 3
- Investigate replacing Batik CSS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from antisamy.