GithubHelp home page GithubHelp logo

(flatten nil) seg faults about ferret HOT 3 CLOSED

nakkaya avatar nakkaya commented on August 24, 2024
(flatten nil) seg faults

from ferret.

Comments (3)

kiranshila avatar kiranshila commented on August 24, 2024

It looks like the problem comes from seqable? as that seg faults for nil.

Your unit test only test one case?

(deftest seqable?-test
  (is (seqable? (list 1 2 3))))

from ferret.

kiranshila avatar kiranshila commented on August 24, 2024

Ok so the problem is the overloaded call to cast

inline seekable_i* var::cast<seekable_i>() const { return obj->cast_seekable_i(); }

This gets called on nullptr when we run (seqable? nil and the obj-> derefs nullptr resulting in a seg fault.

from ferret.

kiranshila avatar kiranshila commented on August 24, 2024

Fixed by replacing

inline seekable_i* var::cast<seekable_i>() const { return obj->cast_seekable_i(); }

with

inline seekable_i* var::cast<seekable_i>() const { return obj != nullptr ? obj->cast_seekable_i() : nullptr;}

from ferret.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.