GithubHelp home page GithubHelp logo

Comments (6)

mirceaulinic avatar mirceaulinic commented on June 10, 2024 1

Totally. Thanks very much for explanation! :)

from napalm-ios.

dbarrosop avatar dbarrosop commented on June 10, 2024

If this works, could we completely get rid of the SCP and just load the file the user is passing into a string? That's actually how it works on the rest of the drivers. Files are usually not involved in the communication with the devices.

from napalm-ios.

ktbyers avatar ktbyers commented on June 10, 2024

Yes, we should leave SCP has the primary mechanism. The Netmiko InLineTransfer is still a file transfer (i.e. writes a file in flash). It also has some file manipulation that goes on to get it work with TCL (i.e. newlines and errors on TCL terminator character).

Because of this the SCP file transfer mechanism should be the default/preferred and the other mechanism an alternative that can be specified via an optional argument.

from napalm-ios.

mirceaulinic avatar mirceaulinic commented on June 10, 2024

Because of this the SCP file transfer mechanism should be the default/preferred and the other mechanism an alternative that can be specified via an optional argument.

I understand this is very tricky, but I do you mean that someone needs to specify a certain flag in order to be able to use device.load_merge_candidate(config='my fancy config')?

A user has to be able to execute both:

  • device.load_merge_candidate(config='my fancy config')
  • device.load_merge_candidate(filename='/path/to/my/file')

This is the behaviour of the rest of the drivers.

from napalm-ios.

ktbyers avatar ktbyers commented on June 10, 2024

@mirceaulinic Yes, it will work as required by the NAPALM API i.e. you can do both of these operations:

device.load_merge_candidate(config='my fancy config')
device.load_merge_candidate(filename='/path/to/my/file')

But by default both of these operations will use Secure Copy.

There will also be a separate optional argument you can specify whereby you can transfer a file completely inside the SSH (or telnet) session using TCL behind the scenes.

This will allow telnet to work and fix the Cisco SCP transfer issue with enable (i.e. that they require a priv 15 account to SCP transfer and you can't do enable).

Does that make sense?

from napalm-ios.

ktbyers avatar ktbyers commented on June 10, 2024

PR for this here #100

from napalm-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.