GithubHelp home page GithubHelp logo

Comments (6)

nutjob4life avatar nutjob4life commented on June 2, 2024 1

@jordanpadams gonna maybe bump this up a little bit more. I've gotten the sendmail issue solved but the next thing that's bugging me is that the Docker image actually contains no code 😦 It's a base PHP image + a custom docker-entrypoint.sh and that's it.

If you were grabbing this image off hub.docker.com and expecting it to do something, you'd be sorely disappointed. The only way it works is if you happen to have the PLAID source layout in the current directory and map the volume /var/www/html to ${PWD}.

This is not a containerized app! 😑

But given it's the long holiday weekend, I'd like to see if I can remedy that too and make the image truly self-contained. You shouldn't need to pull the image and clone the repo! 😅

from plaid.

jordanpadams avatar jordanpadams commented on June 2, 2024 1

thanks for the clarification @nutjob4life ! sounds good. i appreciate the approach here since we don't want to have to re-containerize this app in the future the right way :-)

from plaid.

jordanpadams avatar jordanpadams commented on June 2, 2024

@nutjob4life ☝️

from plaid.

jordanpadams avatar jordanpadams commented on June 2, 2024

@nutjob4life feel free to blow up the README/docs however you see fit. We can continue to use the README, or we can setup Sphinx docs as well if that makes sense. Whatever you think is best.

from plaid.

nutjob4life avatar nutjob4life commented on June 2, 2024

Thanks to log4j vulnerabilities (and the holidays) I'm finally getting to this today. However there are some architectural things I think we should tackle in addition to documentation, the big one being sending email (password registration, etc.). The system is hard-coded right now to use JPL's SMTP server, which works fine if you have JPL VPN but if you're any old open-source developer off the street, you basically can't run this on your desktop.

I can do "just the docs" but I'd like to go a step further and clean up the SMTP configuration, parameterize the docker-compose, clean up the Dockerfile, etc., that it's more like other open-source containers. That's the approach I'm taking right now, so stop me by commenting on this ticket before I go too far 😝

from plaid.

jordanpadams avatar jordanpadams commented on June 2, 2024

@nutjob4life sounds great! Whatever you think makes sense. Do you mind updating the estimate for the ticket?

from plaid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.