GithubHelp home page GithubHelp logo

Comments (3)

VWoeltjen avatar VWoeltjen commented on June 14, 2024

Rephrasing the above:

  1. Remove should be valid (in principle) only for objects with a parent.
  2. Remove should be available (by policy) only when an object's parent can be user-modified (by policy)
  3. User modification of objects that are outside of the current editing scope should be disallowed by policy.

Why not consolidate 1 and 2 and have Remove consult policy about mutation? Because it keeps Remove's dependencies narrow - it only needs to know about the things that are necessary to do its job (it needs to get the parent.)

Why not consolidate 2 and 3 and just have a policy that suppresses Remove specifically in Edit mode? Because then, for every other circumstance where an object should not be modified, it needs to come with its own policy rejecting Remove.

Why not consolidate all of 1 through 3 and have a Remove that is aware of Edit mode? For both of the reasons stated above.

from openmct.

larkin avatar larkin commented on June 14, 2024

I think we've spent enough time on this that we should leave it be. It works well enough right now, any time we have touched it it has broken and been time consuming to fix. It's fragile, policy is fragile, we are assuming too much.

We should focus our efforts elsewhere and come back to this later.

from openmct.

larkin avatar larkin commented on June 14, 2024

At this time we don't have a "correct" solution for this.

Consider this a set of problems that we would take into consideration only while doing a complete review of the editing interface.

Closing as wontfix.

from openmct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.