Comments (3)
Rephrasing the above:
- Remove should be valid (in principle) only for objects with a parent.
- Remove should be available (by policy) only when an object's parent can be user-modified (by policy)
- User modification of objects that are outside of the current editing scope should be disallowed by policy.
Why not consolidate 1 and 2 and have Remove consult policy about mutation? Because it keeps Remove's dependencies narrow - it only needs to know about the things that are necessary to do its job (it needs to get the parent.)
Why not consolidate 2 and 3 and just have a policy that suppresses Remove specifically in Edit mode? Because then, for every other circumstance where an object should not be modified, it needs to come with its own policy rejecting Remove.
Why not consolidate all of 1 through 3 and have a Remove that is aware of Edit mode? For both of the reasons stated above.
from openmct.
I think we've spent enough time on this that we should leave it be. It works well enough right now, any time we have touched it it has broken and been time consuming to fix. It's fragile, policy is fragile, we are assuming too much.
We should focus our efforts elsewhere and come back to this later.
from openmct.
At this time we don't have a "correct" solution for this.
Consider this a set of problems that we would take into consideration only while doing a complete review of the editing interface.
Closing as wontfix.
from openmct.
Related Issues (20)
- Add progress indicator to expanded Time List view
- Condition sets don't show most recent status for Operator/Mission Status on nav HOT 1
- [Telemetry Tables] Table Columns do not seem to respect domain and range metadata values in ordering
- "View Large" mutating its own dependencies HOT 1
- [e2e] Update e2e couchdb tests to support two couchdbs with read-only configured
- Overlay Plot swatches do not handle compressed vertical space well
- [Recent Objects] Add a collapse button to Recents HOT 2
- [e2e] Update visual test for imagery to attempt to use a routed image instead of one provided by the example imagery plugin
- Operator status indicator should check for role when receiving status
- Standardize line feed between description and tags in JSDoc
- Document Mission Status feature
- Open in new tab has stopped working.
- Drag and Drop of telemetry doesn't work in Firefox but works in Chrome. HOT 2
- [Overlay Plots] Removing 1 Object from the Elements Pool Removes 2 from the Legend HOT 4
- Collapsed Recent Items button needs polishing (TEMP)
- [Overlay Plot] Deleting an element via Remove Action breaks the Legend HOT 4
- [Release] Update release documentation to better describe open mct releases
- Large view from flexible layout panel leads to blurry charts and nonworking buttons HOT 2
- [Mobile Support] Supermenus need some tweaking
- Overflow, alignment and padding in text and button elements causing problems HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openmct.