GithubHelp home page GithubHelp logo

Comments (5)

natefinch avatar natefinch commented on June 30, 2024 1

100% ... I'll tag it appropriately.... I'm sad it's already in v2, which makes modules a lot more of a headache.

from lumberjack.

nightlyone avatar nightlyone commented on June 30, 2024 1

Hi @natefinch could you please tag v2.1 also as v2.1.0 ? That would allow using it in Go modules.
Then the the v2.1 will be usable without problems with Go 1.11 up to Go 1.13.

I recently needed to go back to v2.0.0 because of that.

from lumberjack.

karrick avatar karrick commented on June 30, 2024

Also see linkedin/goavro#159 where goavro had already had a v2 branch, but wanted to create a v2 Go module.

GO111MODULE=on go mod init github.com/natefinch/lumberjack.v2
touch go.sum
GO111MODULE=on go test
git add go.{mod,sum}
git commit -m 'Created Go module'
git tag -a v2.1.1 -m 'Created Go module'

from lumberjack.

karrick avatar karrick commented on June 30, 2024

I thought the same thing until someone recommended that I just call the goavro module v2.

I made a mistake above. I should have typed:

GO111MODULE=on go mod init github.com/natefinch/lumberjack/v2

from lumberjack.

karrick avatar karrick commented on June 30, 2024

Because there is already a v2.0 branch, a v2.1 tag, it got messy, so in #89 I just created a new branch, v2.2, and tagged it v2.2.0.

from lumberjack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.