GithubHelp home page GithubHelp logo

Comments (9)

hamiltoncj avatar hamiltoncj commented on June 9, 2024

Sorry I haven't responded sooner. I have been busy with a paper justifying the use of QGIS in our organization. There is the possibility that I may not be allowed to do any more QGIS plugin development.

My question is why would you want to have a variable of the layers you want to search? Why not just select them in the QGIS layer panel and search on them? I don't think the capability you are asking for would be approved to have added to Search Layers.

If you download the new i18n/searchLayers_ja.ts file you can translate , , and strings. Those I can add and update.

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

Thank you for your response.
It is perfectly fine if you answer at your own pace.

We are currently working on the search functionality, both with the search plugin we are creating and with this great plugin.
We are wondering if it would be possible to consolidate to this plugin.
The first step is to make it Japanese.

The second part is to simplify the search screen.
The reason is that we have dozens of layers that we don't need as search targets, but often only a few that we need.
In such cases, we would like to customize it because it is difficult to find the selection target in its current state.

The future proposal is also realistic and has already been implemented in our plugin.
If it suits your purpose, we would be happy to implement it.

If it looks good, I will make a pull request.

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

Thank you for your continued support regarding the translation.
Pull requests for ts files only.

from qgis-searchlayers-plugin.

hamiltoncj avatar hamiltoncj commented on June 9, 2024

I think the changes are reasonable. As far as I can tell the only changes you have made is to searchDialog.py and i18n\searchLayers_ja.ts. You have a different readme.md and several other files created by something, which don't affect the plugin. Do you want me to just replace the two files without you needing to do a pull request? That might prevent some unnecessary files getting merged.

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

That is correct.
In fact, I was baffled when I made a modified PULL request for another plugin in my environment and the whole thing was replaced.
I thought I should learn more about how to PULL in different working environments.
As a result, I now set up a separate repository from the PULL to modify it.

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

The search we use, which we are currently considering integrating, was recently open sourced and is in the process of being generalized.
We will consider it again when that one is completed.
https://github.com/yamamoto-ryuzo/GEO-search-plugin

from qgis-searchlayers-plugin.

hamiltoncj avatar hamiltoncj commented on June 9, 2024

I am not used to working with others on this so this is all new to me as well. Since I came from a C/C++ background I think there is probably a better way to manage the python code rather than using a makefile. It is all a learning process.

Are you planning on doing a pull request with those two files that have changed or do you want me to drop them into my code repo?

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

[do you want me to drop them into my code repo?]
 I'll study it next time.
First of all, I would like to make a PULL request for the realization of custom settings for each project, which is the original purpose of this project.
We will consider other feature proposals as soon as the plugin we have created is generalized.
Thank you in advance.

from qgis-searchlayers-plugin.

yamamoto-ryuzo avatar yamamoto-ryuzo commented on June 9, 2024

#18

from qgis-searchlayers-plugin.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.