GithubHelp home page GithubHelp logo

Comments (12)

derekcollison avatar derekcollison commented on July 21, 2024

Feel free to submit a PR to expose Server such that you can do this. I would also add an entry point to add a new Server instead of pushing directly. This could just take a URI so then you would not have to expose Server.

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

Yup makes sense, addServer(uri) sounds good?

from nats.js.

derekcollison avatar derekcollison commented on July 21, 2024

I think so.

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

Ok, then submitting a PR any point in adding a test for that?

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

n"m I can use nc.close() to test

from nats.js.

derekcollison avatar derekcollison commented on July 21, 2024

Yes please always submit tests for any new functionality or bug fix, just good hygiene.

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

PR submitted

from nats.js.

derekcollison avatar derekcollison commented on July 21, 2024

We need to add some more logic since we normally randomize the array. So we should test that is the case when you add, so we can push but then need to randomize unless there is a flag to suppress.

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

Closed in #79

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

Would it be possible for you to bump version and publish to npm when you got some spare time?

from nats.js.

derekcollison avatar derekcollison commented on July 21, 2024

Yes, I may have a few more things to land first, that ok timing wise or would you prefer earlier?

from nats.js.

1N50MN14 avatar 1N50MN14 commented on July 21, 2024

No worries for my part it can wait 1 - 1.5 weeks

from nats.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.