GithubHelp home page GithubHelp logo

Comments (5)

G-Ambatte avatar G-Ambatte commented on June 18, 2024 1

I think that the only thing that we can rely on is that users expect that the current behaviour of the footnote will continue in the future, so the styling of .footnote should ideally remain unchanged, thus preventing any unexpected changes to existing documents - even if that change is only "this tiny piece of text is all caps now".
It does seem like this would be perfect for the Theme Versioning change that I mentioned in a comment on that issue earlier today (here) to allow users to stay on their current version if they so desired. But that's a pretty enormous change, and ideally Themes will be live and available to users for some time before we even consider beginning work on that feature.

With that said, I'm not strongly for or against either position, and the actual change itself is only a handful of lines of styling; I'm certain that we can quickly knock out a PR to apply the desired change, whatever it might be.

I also really enjoy the discussion; it's great that we have enough people active enough to discuss the issue.

from homebrewery.

G-Ambatte avatar G-Ambatte commented on June 18, 2024

This is an interesting question - SHOULD the text transform to caps? This behavior isn't clearly indicated by the footnote tag, so might be surprising/confusing to users.

I would suggest an alternative styling of .footnote.caps { text-transform: uppercase; } and then adjust the snippet to apply {{footnote,caps [...]}} instead.

from homebrewery.

5e-Cleric avatar 5e-Cleric commented on June 18, 2024

I disagree on that, a footnote has a series of properties, and most off the time, all caps is one of them, i thought it did until i sent that message.

But i don't really care, it won't make my brews any longer, both options are okay.

This is a perfect issue for new users to contribute.

from homebrewery.

Gazook89 avatar Gazook89 commented on June 18, 2024

It’s a stylistic change, to match PHB— I don’t think it is onerous/unexpected that the footnote would be all caps. Same deal as the small caps on the first line after h1 headers.

THAT SAID, we could have a no-caps class that removes the uppercase property (rather than a class that adds it). This could also be applied to a paragraph that has the first line capitalized by using injection curlies, rather than/in addition to the method offered in the Style Editor snippets.

from homebrewery.

5e-Cleric avatar 5e-Cleric commented on June 18, 2024

It is nice the possibility of having a discussion, but we better use our time in interesting features, rather than missing nuances.

I say, add a CAPS class, and let there be riot.

from homebrewery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.