GithubHelp home page GithubHelp logo

compute_time_var is broken about esmlab HOT 3 OPEN

ncar avatar ncar commented on July 1, 2024
compute_time_var is broken

from esmlab.

Comments (3)

matt-long avatar matt-long commented on July 1, 2024 1

That works, thanks. I will need to get to know this code better and perhaps we can discuss how to improve the interface. The original intent was to provide this as a utility for the user.

from esmlab.

andersy005 avatar andersy005 commented on July 1, 2024

@matt-long, because xarray's accessors only accept one argument, which is an xarray.Dataset in this case, I added a somewhat unpleasant hack .esmlab.set_time() to allow passing attributes such as year_offset, time_coord_name to the class' instance.

In order to get compute_time_var to work, try this

ds.esmlab.set_time('time').compute_time_var()

or

ds.esmlab.set_time().compute_time_var()

from esmlab.

andersy005 avatar andersy005 commented on July 1, 2024

In case we don't need to instantiate the accessor with year_offset, time_coord_name attributes, we can remove this hack. Let me know what you think.

from esmlab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.