GithubHelp home page GithubHelp logo

Comments (3)

josevalim avatar josevalim commented on May 20, 2024 1

normalize_template_var can be a prewalk pass. Then, for highlighting variables, you could do a prewalk and wrap them into something that will become __sobelow_highlight__(var) when converted to string. Then do a pass on the string and convert the highlight into ascii. :D

Another option is to do something like this: do a prewalk, create a variable named __sobelow_highlight_#{n}__ for each highlight, and then introduce the variable into the AST instead of the highlight. Then you convert to string and then you replace all __sobelow_highlight_N__ in the output by the specific code you want to highlight

from sobelow.

dennym avatar dennym commented on May 20, 2024

This would be a nice fix. Plenty of github action examples also run mix compile --warnings-as-errors which currently fails due to this.

from sobelow.

houllette avatar houllette commented on May 20, 2024

I'm still getting familiar with the codebase myself, but have started to dig into this a little bit. Looks like from this comment from @josevalim, we may have to just do a prewalk as sort of a pre-pass on the data.

from sobelow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.