Issues with Turbolinks about scrollme

[nckprsn]

Did a quick search: https://github.com/kossnocorp/jquery.turbolinks sounds like it should solve the problem.

I've never worked with Turbolinks but my understanding is that it can easily break a lot of jQuery plugins that rely on certain events to initialise. If the above doesn't work then some changes to ScrollMe's event bindings may be required.

[chrise86]

I'm already using that :(—
Sent from Mailbox

On Tue, Jun 17, 2014 at 5:58 PM, Nick Pearson [email protected]
wrote:

Did a quick search: https://github.com/kossnocorp/jquery.turbolinks sounds like it should solve the problem.

I've never worked with Turbolinks but my understanding is that it can easily break a lot of jQuery plugins that rely on certain events to initialise. If the above doesn't work then some changes to ScrollMe's event bindings may be required.

Reply to this email directly or view it on GitHub:
#3 (comment)

[nckprsn]

Bit of a stab in the dark here - can you try replacing line 374:

$document.ready( function(){ init(); } );

with this:

$document.on( 'ready page:load' , function(){ init(); } );

And let me know if that works?

I realise this probably isn't the right way to do this - am still a bit of a noob with GitHub!

[chrise86]

That seems to solve the first issue!

Still doesnt want to work when hitting that back button though... I'll see if I can do some digging too 😄

[chrise86]

Ok this works:

$document.on( 'ready page:load page:change' , function(){ init(); } );

So, it has to trigger on page:load as normal (incase animation is on the start page), and has to trigger on page:change incase the page has changed to a cached version.

Seems to be the only combo that worked for me... although I could swap either for one or two other event names, but it would still require 2 calls each time...

[nckprsn]

That makes perfect sense.

I'm tempted to include as you've put it but I'm a little unsure about the consequences of attempting to bind to non-existent events.

[chrise86]

Maybe a new branch? :)—
Sent from Mailbox

On Thu, Jun 19, 2014 at 6:55 PM, Nick Pearson [email protected]
wrote:

That makes perfect sense.

I'm tempted to include as you've put it but I'm a little unsure about the consequences of attempting to bind to non-existent events.

Reply to this email directly or view it on GitHub:
#3 (comment)

[nckprsn]

Rather than make a new branch I've added an array of events to bind the init() to so other can easily be added in future if need be. (http://xkcd.com/974/ ...)

As far as I can tell, if the event handler doesn't exist the binding will take place but the event will of course never be fired. Therefore, this shouldn't impact any cases where Turbolinks isn't present. Any further enlightenment on the topic would be most welcome!