GithubHelp home page GithubHelp logo

Comments (2)

ndilieto avatar ndilieto commented on April 20, 2024

I think you are right. nsupdate.sh was contributed by Michel Stam, so let's ask him what he thinks before deciding how to fix it.

@MichelStam have you got any comments on this?

from uacme.

MichelStam avatar MichelStam commented on April 20, 2024

Hi,

Good review.

  • I agree that subdomains are not handled as best as they should. Intention is to extract the NS records to see which nameservers need to be tested for the presence/absence of the acme record. The dig for the SOA record is to verify which server qualifies as the primary NS and will get the nsupdate command.
  • Dropping RNDC_KEY entirely would break multi-view DNS setups. By utilising the key you can force the correct view to be shown to dig.
  • Script was written for bash, so probably changing it to bash would be preferable
  • gethostname is indeed not used anymore. It was in an older version of the script and could be removed.

Cheers,

Michel

from uacme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.