Interactive-Shell Issue: <env_name>: command not found about conda.el

[louisdecharson]

Having the same here ! Any news @hnisonoff ?

[louisdecharson]

I've tried to debug it and for some reason activate-command is not set after

(activate-command (if (eq system-type 'windows-nt
                                   '("activate")
                                   '("conda" "activate"))))

e.g.:

(message "activate command: %s" activate-command)

yields: activate-command: nil

I've ended up modifying the function conda-env-shell-init in conda.el as:

;;;###autoload
(defun conda-env-shell-init (process)
  "Activate the current env in a newly opened shell PROCESS."
  ;; TODO: maintain compatibility with an older Conda version. Do we
  ;; check the Conda version and cache it?
  ;; TODO: make sure the shell has been set up for `conda activate`!
  ;; Do we need to `eval' the conda activation script every time?
  (let* ((activate-command (if (eq system-type 'windows-nt
                                   '("activate")
                                   '("conda" "activate"))))
         (activate-command (if (not activate-command) '("conda" "activate") activate-command))
         (full-command (append activate-command `(,conda-env-current-name "\n")))
         (command-string (combine-and-quote-strings full-command)))
    (comint-send-string process command-string)
    ))

[necaris]

Could you submit that as a PR, perhaps? Louis de Charsonville ***@***.***> writes:

…

I've tried to debug it and for some reason activate-command is not set after (activate-command (if (eq system-type 'windows-nt '("activate") '("conda" "activate")))) e.g.: (message "activate command: %s" activate-command) yields: activate-command: nil I've ended up modifying the function conda-env-shell-init in conda.el as: ;;;###autoload (defun conda-env-shell-init (process) "Activate the current env in a newly opened shell PROCESS." ;; TODO: maintain compatibility with an older Conda version. Do we ;; check the Conda version and cache it? ;; TODO: make sure the shell has been set up for `conda activate`! ;; Do we need to `eval' the conda activation script every time? (let* ((activate-command (if (eq system-type 'windows-nt '("activate") '("conda" "activate")))) (activate-command (if (not activate-command) '("conda" "activate") activate-command)) (full-command (append activate-command `(,conda-env-current-name "\n"))) (command-string (combine-and-quote-strings full-command))) (comint-send-string process command-string) )) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

-- Rami Chowdhury A mind all logic is like a knife all blade - it makes the hand bleed that uses it. -- Rabindranath Tagore

[louisdecharson]

Hi @necaris,
To me your code should work just fine, ie:

((activate-command (if (eq system-type 'windows-nt
                                   '("activate")
                                   '("conda" "activate"))))

I don't understand why it does not.
So I am happy to submit a PR but I feel my solution is more a plaster than anything else and a more appealing solution would fix the let activate-command part.

UPDATE: understood the issue in above code and submitted a PR to fix it

[louisdecharson]

Ok got the issue, it's was a simple parenthesis problem, I've submitted a PR to fix it:
#95

[necaris]

Closing as fixed by #95