necolas / delegate.js Goto Github PK

See:
necolas/matches.js@6ac4a28

Related chai issue:
chaijs/chai#175

Could we simplify this lib by relying on your closest implementation? It seems the whole of this function can be replaced with a call to closest?

So, this line could be replaced as so:

if (e.delegateTarget = closest(e.target, selector, elem)) {

Aside: I intended to submit PR for this. Couldn't get npm to install as-is (needed to update Karma), and then I couldn't get tests to run

Should probably clean up and not leave the wrapped function attached to the callback once it's been removed.

This change would involve creating a registry to keep track of the element-delegate-callback relationship. It would avoid a callback for a given event type being unbound for all delegators, rather than just the delegator you're interested in.

An object that implements EventListener interface (https://developer.mozilla.org/en-US/docs/Web/API/EventListener) has a handleEvent method. e.g.:

var obj = {
  log : function(e) {
    console.log("event", e.type, "happened on", e.target);
  },
  handleEvent : function(e) { 
     this.log(e); 
  }
};

Notice that the this value in handleEvent is bound to the object itself. As obj implements the EventListener interface, it can be registered directly as an event listener:

document.addEventListener("click", obj, false);

It would be great if the EventListener interface was respected by delegate.js and worked as one would expect:

delegate(body).on("click", ".some-selector", obj);