GithubHelp home page GithubHelp logo

Comments (6)

ivan-aksamentov avatar ivan-aksamentov commented on May 12, 2024

This is a huge issue (in terms or amount of work). Feel free to open separate issues for smaller fixes and mention this one.

from covid19_scenarios.

miksa1987 avatar miksa1987 commented on May 12, 2024

Hi! I could start working on the elements. As for clicking run and more items appearing, could it be done so that form items would be kind of like menu overlay on top of everything, and when clicking run, they go away to a menu button ready to be invoked again?
Also, I was thinking about the popups in graphs, perhaps they should be placed on top of the graph on mobile, so that it wouldn't be on top of the pointer making it hard to tap on certain spot?

from covid19_scenarios.

ivan-aksamentov avatar ivan-aksamentov commented on May 12, 2024

Hi @miksa1987,

I could start working on the elements

It'd be awesome! Make sure you coordinate with other folks, such as in #83 and other issues and PRs listed above

form items would be kind of like menu overlay on top of everything, and when clicking run, they go away to a menu button ready to be invoked again

That's a great design idea!

about the popups in graphs, perhaps they should be placed on top of the graph on mobile

That'd be fantastic! Although, I am not sure if our graph library allows that to be done easily or even at all. But I'd be glad if you can look into it!

Please, in order to ensure that the merge conflicts are small and there is no work wasted on different people doing the same thing, keep your work constantly visible:

  • commit and submit or update PRs often
  • optionally mark PRs as "draft"
  • optionally create an empty "WIP" or "DO NOT MERGE" PR and keep pushing new commits into it
  • discuss and coordinate in our Spectrum chat (in dev channel)

from covid19_scenarios.

miksa1987 avatar miksa1987 commented on May 12, 2024

form items would be kind of like menu overlay on top of everything, and when clicking run, they go away to a menu button ready to be invoked again

That's a great design idea!

about the popups in graphs, perhaps they should be placed on top of the graph on mobile

That'd be fantastic! Although, I am not sure if our graph library allows that to be done easily or even at all. But I'd be glad if you can look into it!

I'm going to look deeper into these two today for starters and open an issue when I'm ready to start working. I really hope your graph library makes it easy(or even possible, like you said) to adjust the popup position based on, for example, media queries. Personally that was a major annoyance when I tried this on my phone.

I'll do this by starting a "DO NOT MERGE" PR first and when it's ready, I'll change the title?
I will join the chat too.

from covid19_scenarios.

ivan-aksamentov avatar ivan-aksamentov commented on May 12, 2024

@miksa1987 Sounds like a plan!

I'll do this by starting a "DO NOT MERGE" PR first and when it's ready, I'll change the title?
I will join the chat too.

Yes, you can remove the "WIP" or "DO NOT MERGE" status or draft flag and and I'll review and merge. You may also ping me with @ivan-aksamentov to make sure I pay attention :)
And of course, let me know if you need something.

from covid19_scenarios.

ivan-aksamentov avatar ivan-aksamentov commented on May 12, 2024

There's been numerous PRs and mobile experience is somewhat better now.
We will address the remaining concerns in more focused issues.

from covid19_scenarios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.