GithubHelp home page GithubHelp logo

BUG: Crash on link creation about imnodes HOT 4 CLOSED

nelarius avatar nelarius commented on August 22, 2024
BUG: Crash on link creation

from imnodes.

Comments (4)

PossiblyAShrub avatar PossiblyAShrub commented on August 22, 2024 1

I just tested the new commit. Everything seems to be working! Thank you for your time :)

from imnodes.

Nelarius avatar Nelarius commented on August 22, 2024

I suppose you're getting an assert in OptionalIndex::value()? If snap_link_idx has a value, then it is an error for end_pin_idx to not have a value, and there's a bug in the code somewhere 🤔

It should actually be OK to intertwine nodes and links, since link rendering is actually now deferred until EndNodeEditor. I need to update the documentation on that.

from imnodes.

Nelarius avatar Nelarius commented on August 22, 2024

Hi @PossiblyAShrub ! Wasn't able to reproduce this problem, but I just pushed the commit 4ccf2f1 to master. It adds the end_pin_idx.has_value() check to, IMO, the correct place: snapping_pin_changed will be false when !end_pin_idx.has_value(). Can you check if it solves your issue?

from imnodes.

PossiblyAShrub avatar PossiblyAShrub commented on August 22, 2024

Sure! I’m out of town for the weekend, but on Monday I’ll check.

from imnodes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.