`skipLine(...)` does not properly handle '\r\n' cases about openfbx

[nem0]

Hi, I can't reproduce the issue. I see skipLine correctly handling comments in \r\n mode. Do you have an fbx file I can try to reproduce this?

[TomTheFurry]

I amon the phone atm so can't give a sample right now, but basically, in here:

https://github.com/nem0/OpenFBX/blob/1c1e86380c5cc78180083d9aed30ff115cf55774/src/ofbx.cpp#LL779C5-L779C6

if (cursor->current < cursor->end) ++cursor->current;

While the 'next line' token is detected correctly on the loop before the linked line, which advances the cursor til it hit the 'next line' token, the linked line then, disregard whether it is a '\n' or '\r\n', and instead just advances 1 character. This makes the 'skipLine()' to fail to skip the actual line.

[nem0]

what happens in case of ;comment\r\n is:

1. cursor goes up to \r
2. isEndLine returns false for \r because it fails on *(cursor.current + 1) != '\n' (emphasis on !=)
3. cursor moves further to \n
4. isEndLine returns true now
5. cursor is move further by one character if (cursor->current < cursor->end) ++cursor->current; so the whole line is correctly skipped

I must be misunderstanding something.

[TomTheFurry]

Oh. That's my mistake then. Apologies for wasting your time here. I did not notice that is a 'not equal' sign instead of a 'equal' sign.

[nem0]

No problem.