[Feature] Convert ScriptHash to Address about neo-vm

[erikzhang]

Why we need to store a string address to storage?

[erikzhang]

I don't think it's necessary to translate the address within the contract.
If you want to translate it outside of the contract, it is very easy. See https://github.com/neo-project/neo/blob/master/neo/Wallets/Wallet.cs#L391

[revett]

Thanks for the reply @erikzhang 👍

If you prefix the storage key with the user's address then they cannot alter any other user's storage:

For example:

ALZzNsLg5CaF1Qa2TSdWB1AawLxFUbKhHz.total_tokens => 3485

This is particularly important in NeoAuth where login proofs are being stored in the contract.

You can read more about the issue in NeoAuth here: https://github.com/neoauth/whitepaper#limitations

[erikzhang]

What about just store the ScriptHash?

[revett]

@erikzhang So the storage action would be:

key:       <script_hash>.total_tokens
value:     3485

And then to read the storage value via the getstorage RPC call you would use the following as the key parameter:

<script_hash>.total_tokens

But how can you translate ScriptHash into Address string?

It may be fixed within this feature request: neo-project/neo#128. As prefixes would fix the issue that the NeoAuth contract is having.