[Feature Request] Hash table type about neo-vm

[dicarlo2]

Hey @erikzhang I see that you added the enhancement label, does that mean we'll see this implemented soon?

[erikzhang]

I wonder if it should be an API to provide the functionality of a hash table.
Like this: Neo.Utility.CreateHashTable

[dicarlo2]

@erikzhang It could be a bunch of syscalls that map to the opcodes proposed above and I'm not opposed to making it a syscall, but to me it feels like something that should be native to the vm, similar to arrays. Either way, we would need to implement an IEqualityComparer for the StackItems that are valid keys and it seems like for better future proofing it would make sense to implement it in the neo-vm project in case we add more StackItem types in the future.

[erikzhang]

We just need MapStackItem, right? I didn't see the necessity of DictStackItem.

[dicarlo2]

@erikzhang Yea, I just added DictStackItem for consistency with StructStackItem. If we don't add DictStackItem it might be nice to have an op code for shallow cloning a DictStackItem.

[dicarlo2]

@erikzhang Checking in, is this something that we'll see implemented as described in the spec? (Except for the StructStackItem)

This is a feature I'd like to make use of for the TypeScript compiler, so if you're planning on implementing it like the spec I'll go ahead and start developing against it.

[erikzhang]

Hi @dicarlo2 , please review #28 .

[localhuman]

This is awesome, adding support in neo-python now. Not sure how I missed it!

@erikzhang @dicarlo2 do you have any sample .avm I can use to test with?

[dicarlo2]

@localhuman Sorry, a little late on the reply (cleaning up notifications). I do not currently have a sample .avm to test with, I just tested using manual unit tests.