Comments (9)
The most direct advantage is that after removing PushOnly
, we can use the instructions such as NEWARRAY
, NEWSTRUCT
, PACK
to create parameters in Neo.Core.Witness::InvocationScript
. And there's no reason to limit it now.
from neo-vm.
Currently, it is for Verification
only.
from neo-vm.
@shargon Do you think it's ok to remove PushOnly
?
from neo-vm.
I think we can remove PushOnly
. Can you evaluate the security if we remove PushOnly
and allow all the instructions in Neo.Core.Witness::InvocationScript
? @shargon
from neo-vm.
I do not really like the idea of removing PushOnly
because it could cause them to execute any code without the need for a smartContract. I think that you can not eliminate PushOnly
, What benefits could it bring?
I Asked by RET
to avoid fattening the script with unnecessary code type
PUSH ORIGINAL_PARAMETERS
RET
PUSHBYTES...
PUSHBYTES...
PUSHBYTES...
PUSHBYTES...
PUSHBYTES...
And the execution is still valid, but it would make the chain fatter
from neo-vm.
All these instructions are executed in a different ExecutionContext, so there is not possible to change storages of the contract. But it could be used to invoke TXs and these TXs could create a different StorageContext to save arbitrary data
from neo-vm.
Contracts can't save any data if they are started with Verification
trigger.
from neo-vm.
But this pushOnly
flag is not only used under Verification
, is used for arguments of invokes too, right?
from neo-vm.
Yes, itβs ok for me π
from neo-vm.
Related Issues (20)
- Add 'utf8Size' opcode HOT 4
- Script checks are incomplete
- Can I integrate this vm in to my custom projects? HOT 1
- Efficient way to pass Map type to contract method? OpCode.PACKMAP? HOT 1
- Adapt code documentation of UNPACK opcode
- ReferenceCounter can become negative HOT 18
- Is this `MEMCPY` expected to push nothing to the stack?
- ScriptBuilder should have an emitPush overload that takes a ReadOnlySpan<byte>
- How to customize an interface in interoperation service layer HOT 3
- Presssure test on v3.3.0 cause execution failed HOT 1
- v3.3.0 need more than 30 hours for syncing mainnet even it's just about 1.7million blocks HOT 2
- What is the purpose of the second assert of this test? HOT 1
- Instruction pointer reading PUSHDATA4 operand size as *signed* int32 HOT 1
- Missing push in APPEND?
- EmitPush(bool) should convert stackitem to right type
- Buffer to Integer conversion inconsistency HOT 1
- Override GetString for Buffer/ByteString ? HOT 4
- Set Operation in a Get Function HOT 2
- Add Equatable for StackItem
- Problem trying to PICKITEM from ByteString and then CAT ByteString and a single Byte picked from ByteString HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neo-vm.