Make nodeSelector Fully Compatible with Karpenter about helm-charts

[harshitsinghvi22]

We currently do not support Karpenter @chakatz
We might look to support it in future but for time being we will not be providing any support

[AzSiAz]

I think nodeSelector is broken:

failed to create chart from template: execution error at (neo4j-cluster-core/templates/_helpers.tpl:52:16): No node exists in the cluster which has all the below labels (.Values.nodeSelector)
     %smap[k8s.scaleway.com/pool-name:neo4j-dev]

No Karpenter, just autoscaler but in my case the nodes are there and will always be but helper function doesn't see them either way

It's a nice addition but I don't think its the job of the helm chart to check this kind of thing at runtime, at least without a way to disable it

[joywaves]

Like @AzSiAz mentioned, some is up in "neo4j.checkNodeSelectorLabels" in _helpers.tpl.
helm lint though an error when nodeSelector has entry:

helm lint --debug -f values.yaml
engine.go:180: [INFO] Fail: No node exists in the cluster which has all the below labels (.Values.nodeSelector)
 %smap[agentpool:neo4j-node]
==> Linting .

1 chart(s) linted, 0 chart(s) failed

[lucasarrudatrustly]

Same problem here, it's the helpers error, it's not about the karpenter.

[harshitsinghvi22]

@lucasarrudatrustly @joywaves
this can be resolved in 4.4 helm charts by passing the --set disableLookups=true . This flag is released in 4.4.17 helm charts
The change will be release in version 5 too in the next upcoming release

[lucasarrudatrustly]

I'm using on 5.4 (must be 5+ for us) I managed to the same effect using affinity, but it's not the best way.
Waiting for the fix I hope that is before production setup
@harshitsinghvi22 Thank you for the reply

[harshitsinghvi22]

closing this as the disableLookups = true was release with version 5 long time ago