Comments (7)
Hey @jelmerderonde. It would be good to know some more details about the error. Perhaps you could paste a gist showing it? Or a bare minimum example project that makes the error happen because the tests for Devise with neo4j all seem to be passing fine.
If you just wanted a quick-ish fix, you could try extending Recoverable and overwriting the after_password_reset method (which is empty in Devise's Recoverable module), to set whatever you need in order for the error not to occur.
from devise-activegraph.
Hi @benjackson,
Thanks for the quick reply. A gist showing the rails server output when the error occurs: https://gist.github.com/jelmerderonde/2930788bfed7b80f4b2b
A minimum project would frankly be just rails, neo4j and devise-neo4j, with a single User resource with the Recoverable module. When a user tries to reset their password, because devise tries to set the reset_sent_at to nil which is not accepted.
I did some more research and I think it might be because of this commit in neo4jrb:
neo4jrb/activegraph@f8689b5#diff-3fa03f2e2089eba3ae28988a375ac16a
However I'm not sure of this. I will try to implement the fix you mentioned, but if you have any suggestion on what I can do to implement a more complete fix let me know.
from devise-activegraph.
Sorry for coming into this a little late. I'm still a little unsure about how it's getting to the point that it can try to convert a nil value. Do we know where reset_sent_at
is defined?
from devise-activegraph.
@subvertallchris I think it is here:
https://github.com/plataformatec/devise/blob/master/lib/devise/models/recoverable.rb
line 85
from devise-activegraph.
@jelmerderonde I haven't tried a real example yet, but any idea why this integration test that gets run as part of all the devise tests wouldn't suffer from the same issue you're seeing?:
https://github.com/plataformatec/devise/blob/master/test/integration/recoverable_test.rb
from devise-activegraph.
@benjackson is there a way I can run these tests in the context of my app? I will take a look at it.
from devise-activegraph.
@jelmerderonde you could just recreate the integration test that covers the functionality that is breaking for you, but that might still be something attributable to your app rather than the gem.
If you're able to create an example in a public repo, with a failing integration test, I'd be happy to take a look and see if I can figure out why the Devise test doesn't capture the same problem.
from devise-activegraph.
Related Issues (20)
- Email translation missing: en.neo4j.errors.models.user.attributes.email.taken HOT 8
- "Could not find a valid mapping" Error on Update HOT 17
- Email addresses are lost after a few logins HOT 15
- `remember_token` property is missing in model generator HOT 1
- Does devise-neo4j support token authentication HOT 2
- confirmation sent with sign in and sign out HOT 4
- Having an issue with custom devise controllers HOT 9
- `:unconfirmed_email` missing from model generator HOT 1
- adding railtie HOT 7
- Upgrading to neo4j.rb 8.0 and neo4j-core 7.0.0 breaks Devise code HOT 3
- Unable to set null to false on model HOT 7
- Gemfile.lock tied to rails 4.2.3 in Windows HOT 4
- Can't get notification email when user change password HOT 1
- Frozen App during user registration HOT 2
- Generates two migrations with the same timestamp HOT 2
- rails g neo4j:active_graph User error HOT 1
- rake neo4j:migrate error HOT 1
- Can't install HOT 2
- Devise 2.1.2 support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devise-activegraph.