GithubHelp home page GithubHelp logo

Instance of puppeteer about convert-svg HOT 2 OPEN

neocotic avatar neocotic commented on May 23, 2024 1
Instance of puppeteer

from convert-svg.

Comments (2)

Nysosis avatar Nysosis commented on May 23, 2024

I was going to raise an issue for something very related, but thought I'd mention it in this issue instead.

Puppeteer also supports connecting to a remote instance via the .connect method, and I was hoping to be able to use this method of connecting to a browser instead of launching a new one up.

However if convert-svg supported providing your own puppeteer instance, then I can .connect() myself, and provide that instance through.

from convert-svg.

neocotic avatar neocotic commented on May 23, 2024

Sorry for the super late response but this is not currently possible but could be. However, I would ask why not simply call createConverter to get an instance of Converter that reuses the same instance of puppeteer until Converter#destroy is called. I feel like this should offer sufficient control over resource management but I'm happy to accept pull requests that expand on this.

I would also like to point out that these packages are designed to be a quick-and-dirty and the whole reason we're using puppeteer under the hood is to get first class SVG rendering without any crazy native building or porting. I'd rather not get too involved with puppeteer itself unless there's genuine use cases that the currently API does not support.

from convert-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.