GithubHelp home page GithubHelp logo

Comments (7)

hrsh7th avatar hrsh7th commented on July 24, 2024 1

Thank you. @alcolmenar
It seems that was my mistake.

As far as I know, neovim has a policy of complying with the LSP specifications, but TextEdit is implemented based on the behavior of VSCode.

from neovim.

scohen avatar scohen commented on July 24, 2024 1

The changes should be applied as given by the language server. You shouldn’t reorder them

from neovim.

alcolmenar avatar alcolmenar commented on July 24, 2024

If possible, I'd like to take this issue on if the team decides that it should be fixed.

from neovim.

mfussenegger avatar mfussenegger commented on July 24, 2024

If possible, I'd like to take this issue on if the team decides that it should be fixed.

Sounds like a bug so yes, a PR with a fix and a test case would be great

from neovim.

scohen avatar scohen commented on July 24, 2024

Hi there, I'm the author of an LS for elixir, and I'm actually wondering why you're sorting the edits at all, since the spec declares that the order of the edits can be important. Sorting the text edits seems incorrect to me, since language servers are putting them in the order they send them for a reason.

from neovim.

scohen avatar scohen commented on July 24, 2024

@mfussenegger Can you please explain the thinking behind reordering the list of changes the language servers send you?

from neovim.

kyoh86 avatar kyoh86 commented on July 24, 2024

📝 This change causes the line positions in the formatting results by efm-langserver to be swapped.
It needs to research where is a bug...

from neovim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.