toPromise() Marked as deprecated about axios

[kamilmysliwiec]

With toPromise() being deprecated, we are left with an Observable - this is quite a big API change!

According to RxJS migration guide, you should be able to replace toPromise() with the lastValueFrom.

Prev:

this.httpService.get(serviceUrl).toPromise();

Current:

lastValueFrom(this.httpService.get(serviceUrl))

That's a pretty simple change

[Izhaki]

Shouldn't the migration guide be updated?

And I can't help the feeling that this conclusion isn't great for developers using NestJS - we are required to change many lines of code and add imports directly from RxJS - just to get what seems to be the sensible API.

It also means this module diverges from the NestJS API, which states:

The above code is fully valid. Furthermore, Nest route handlers are even more powerful by being able to return RxJS observable streams. Nest will automatically subscribe to the source underneath and take the last emitted value (once the stream is completed).

So this is the case for NestJS, but not @nestjs/axios.

[kamilmysliwiec]

Shouldn't the migration guide be updated?

toPromise() is deprecated, not removed. Also, this change comes from the RxJS so you should navigate to the RxJS migration guide for more information on the breaking changes they've made.

The above code is fully valid. Furthermore, Nest route handlers are even more powerful by being able to return RxJS observable streams. Nest will automatically subscribe to the source underneath and take the last emitted value (once the stream is completed).

This statement is still correct.

Please, use our Discord channel (support) for such questions. We are using GitHub to track bugs, feature requests, and potential improvements.