GithubHelp home page GithubHelp logo

Comments (22)

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024 2

Will go through the code, let me take this.

from azure-database.

abouroubi avatar abouroubi commented on April 23, 2024 2

First version here : https://github.com/abouroubi/azure-database/tree/feature/cosmosdb

from azure-database.

DenzoNL avatar DenzoNL commented on April 23, 2024 2

I'll be trying it out later today :)

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024 1

@santoshyadav198613 yes the repo has been moved to https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos but the package remains under the same scope @azure/cosmos.

@abouroubi this looks awesome! Would you mind adding more info to the readme? Also, would you like to contribute your code to this project? @santoshyadav198613 and I would be happy to help you get a PR ready for the final stage. WDYT?

from azure-database.

abouroubi avatar abouroubi commented on April 23, 2024 1

Hey guys, yes I'll add the details to the documentation. I think that what I've done is light, I'm planning on adding DateTime and Geospatial data types, (https://docs.microsoft.com/en-us/azure/cosmos-db/working-with-dates) as decorators. And eventually a base class Repository, like the table storage one

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024 1

Yeah, it's a very good start!!
Feel free to open a PR and let's move the discussion there.

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024 1

@DenzoNL @santoshyadav198613 @abouroubi I have some issues pushing changes to this repo. While we fix that, I have cloned this repo at https://github.com/manekinekko/azure-database and pushed the Cosmos DB support that master.

Please give it a try and let us know if things are working as expected.

from azure-database.

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024 1

Great I will try it tomorrow 🙏

from azure-database.

abouroubi avatar abouroubi commented on April 23, 2024 1

Hi there,
Happy to see that the PR is merged, I'm planning on adding more control over the indexing policies, and maybe a generic repository
If you have any ideas, or want to work on any of these I'll be happy to discuss them.

from azure-database.

DenzoNL avatar DenzoNL commented on April 23, 2024 1

@abouroubi A generic repository and a decorator to inject it would be amazing! We can then simply inject that for simple CRUD services, and in case more control is needed, we could extend the generic repository or inject the container itself.

EDIT: @abouroubi @manekinekko I've taken the liberty to draft a PR (#110) for the generic repository, would you be so kind to take a look at it and provide some feedback? I'm rather new to the whole custom dynamic provider thing in Nest.js :)

from azure-database.

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024

As per repo, the code is moved to https://github.com/Azure/azure-sdk-for-js should i refer the same?

from azure-database.

abouroubi avatar abouroubi commented on April 23, 2024

Hello @santoshyadav198613, I'm working on the same integration of CosmosDB into NestJS, I've already implemented the same behavior as the official Mongoose module.

What are your plans on this, maybe we can work on it together ?

from azure-database.

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024

sure @abouroubi, which sdk you have used?

from azure-database.

abouroubi avatar abouroubi commented on April 23, 2024

the '@azure/cosmos' as per the docs: https://docs.microsoft.com/en-us/azure/cosmos-db/sql-api-nodejs-application

from azure-database.

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024

Ok, as per GitHub @azure/cosmos is moved to the new repository lets wait for the confirmation from @manekinekko.

from azure-database.

santoshyadavdev avatar santoshyadavdev commented on April 23, 2024

Thanks @abouroubi awesome job buddy, will do the review soon.

from azure-database.

DenzoNL avatar DenzoNL commented on April 23, 2024

Great to see efforts being made on supporting Cosmos DB :) What's the status on this? And does it support multi-master?

from azure-database.

DenzoNL avatar DenzoNL commented on April 23, 2024

@manekinekko So far it's working correctly in my own CRUD example, so that's great! I only had a couple of issues with some typo's causing the build to break, so it didn't work out of the box. I can create a PR to fix this, would you like me to do this in https://github.com/nestjs/azure-database or in https://github.com/manekinekko/azure-database ?

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024

Please create the PR on my fork for now.

from azure-database.

DenzoNL avatar DenzoNL commented on April 23, 2024

@manekinekko I've submitted the PR: manekinekko#1 it should build properly with this :)

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024

Hi @abouroubi that's fantastic!

Could you send your PR against my temporary fork (https://github.com/manekinekko/azure-database)? I still can't push to this repo (@kamilmysliwiec is looking into this). I will merge everything back into this project once the situation is resolved 🙏

Everything is back to normal now.

from azure-database.

manekinekko avatar manekinekko commented on April 23, 2024

Closing this issue as Cosmos DB initial support has been added by #36. Please open a new issue to discuss the generic repository idea.

from azure-database.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.