GithubHelp home page GithubHelp logo

Comments (5)

kamilmysliwiec avatar kamilmysliwiec commented on April 26, 2024 1

One small fix:

@NgModule ---> @Module

Notes:

  1. Having an interceptor is a great idea, but we should also expose an injectable service so that people will be able to conditionally upload some files (based on some custom logic).
  2. The naming convention might be slightly confusing, Azure has lots of services 😄

from azure-storage.

kamilmysliwiec avatar kamilmysliwiec commented on April 26, 2024 1

@manekinekko sounds great!

from azure-storage.

marcus-sa avatar marcus-sa commented on April 26, 2024 1

This would make a great addition, but IMO it'd just be reinventing the wheel because of https://github.com/pulumi/pulumi

I don't know, that's just my opinion 😸

from azure-storage.

manekinekko avatar manekinekko commented on April 26, 2024

Having an interceptor is a great idea, but we should also expose an injectable service so that people will be able to conditionally upload some files (based on some custom logic).

Gotcha.

The naming convention might be slightly confusing, Azure has lots of services 😄

I know. Naming is hard. What about AzureStorageInterceptor ?

from azure-storage.

manekinekko avatar manekinekko commented on April 26, 2024

Thank you @marcus-sa for sharing this. However, this module and Pulumi are not targetting the same use case. This @nestjs/azure-storage module isn't meant to be an Infrastructure as Code type of tool. This is a helper for NestJs users to be able to store their file/content on Azure.

from azure-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.