Comments (6)
Thanks for reporting this @maksimkurb 🥇
It's nice to see that you prepared the failing test that can confirm your bug report. Could you create the pull request before we continue to work on this?
from bull.
Closing in favor of #89
from bull.
Don't close an issue until it's resolved.
from bull.
I believe this is rather an error in the BullModuleAsyncOptions
interface:
export interface BullModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
name?: string;
useExisting?: Type<BullOptionsFactory>;
useClass?: Type<BullOptionsFactory>;
useFactory?: (
...args: any[]
) => Promise<BullModuleOptions> | BullModuleOptions;
inject?: any[];
}
should be
export interface BullModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
name?: string;
useExisting?: Type<BullModuleOptions>;
useClass?: Type<BullModuleOptions>;
useFactory?: (
...args: any[]
) => Promise<BullModuleOptions> | BullModuleOptions;
inject?: any[];
}
I'll try to have a look at this by the end of the week.
In the meantine, I think you could refactor your async configuration and use useFactory
instead of useClass
.
from bull.
I think I'll have a look at your PR and try to fix the current implementation of the useClass
alternative without breaking the interface. But keep #94 in mind. I might change this behavior pretty soon.
from bull.
Since this is broken, I've made my mind to directly "fix" this through #94. I'm therefore closing this in favor of #94.
from bull.
Related Issues (20)
- Get process and processer metadata HOT 1
- Support processor with observables HOT 1
- Support multiple rate limits HOT 1
- Processors with multiple processes inconsistently process jobs HOT 1
- BullModule.registerQueue duplicates Module load HOT 2
- Global concurrency limit HOT 5
- Not initialising the processor with decorator HOT 1
- Facilitate queue metrics collection HOT 2
- Bull does paralel job when in processor implemented more processes. HOT 1
- Bull events + Nestjs request scoped dependencies
- Support BullMQ v5.0.0 HOT 3
- Bull Module not connecting as expected HOT 1
- Missing WorkerOptions types on BullQueueAdvancedProcessor and BullQueueAdvancedSeparateProcessor HOT 1
- options.family is not cast to number if given in REDIS_URL HOT 1
- Bull support for durable request scoped processors. HOT 4
- Give ability to disable job processing in `BullModule.forRoot` method HOT 1
- Mismatch with bull HOT 2
- NestJS Bull appears to be utilizing Upstash Redis unnecessarily. HOT 1
- Controls for nestjs/bullmq processors in request-scoped providers HOT 4
- Ability to accept/reject jobs before being processed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bull.