GithubHelp home page GithubHelp logo

Comments (6)

fwoelffel avatar fwoelffel commented on April 19, 2024

Thanks for reporting this @maksimkurb 🥇
It's nice to see that you prepared the failing test that can confirm your bug report. Could you create the pull request before we continue to work on this?

from bull.

maksimkurb avatar maksimkurb commented on April 19, 2024

Closing in favor of #89

from bull.

fwoelffel avatar fwoelffel commented on April 19, 2024

Don't close an issue until it's resolved.

from bull.

fwoelffel avatar fwoelffel commented on April 19, 2024

I believe this is rather an error in the BullModuleAsyncOptions interface:

export interface BullModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
  name?: string;
  useExisting?: Type<BullOptionsFactory>;
  useClass?: Type<BullOptionsFactory>;
  useFactory?: (
    ...args: any[]
  ) => Promise<BullModuleOptions> | BullModuleOptions;
  inject?: any[];
}

should be

export interface BullModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
  name?: string;
  useExisting?: Type<BullModuleOptions>;
  useClass?: Type<BullModuleOptions>;
  useFactory?: (
    ...args: any[]
  ) => Promise<BullModuleOptions> | BullModuleOptions;
  inject?: any[];
}

I'll try to have a look at this by the end of the week.

In the meantine, I think you could refactor your async configuration and use useFactory instead of useClass.

from bull.

fwoelffel avatar fwoelffel commented on April 19, 2024

I think I'll have a look at your PR and try to fix the current implementation of the useClass alternative without breaking the interface. But keep #94 in mind. I might change this behavior pretty soon.

from bull.

fwoelffel avatar fwoelffel commented on April 19, 2024

Since this is broken, I've made my mind to directly "fix" this through #94. I'm therefore closing this in favor of #94.

from bull.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.