nestjs / class-validator Goto Github PK

Did you read the migration guide?

• I have read the whole migration guide (there is none)

Is there an existing issue that is already proposing this?

• I have searched the existing issues

Potential Commit/PR that introduced the regression

PR #72

Versions

0.13.3 -> 0.13.4

Describe the regression

Hi,

We upgraded to @nestjs/[email protected] and receive the following error during nest build:

Could not find a declaration file for module 'validator'.
Try `npm i --save-dev @types/validator` if it exists or add a new declaration (.d.ts) file containing `declare module 'validator';`

I saw that #72 removes the dependency.
Has this been an accidental merge issue or are we expected to install @types/validator ourselves?

Cheers,
Steffen

Minimum reproduction code

No response

Expected behavior

@nestjs/class-validator should work out-of-the-box.

Other

No response

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

Hi, I am try use validation in NestJS follow document, I need send this query "/api/tournaments/TournamentsList?filterBy=id&filter=1&searchBy=title&search=akiira" is normally query and this my function in controller

`@Get('TournamentsList')
@ApiCreatedResponse({ type: MessageResultAPIModel })
@UsePipes(new ValidationPipe())
async TournamentsList(
@query() dataQuery: QueryObject
) {
try {
console.log(dataQuery.filterBy)
return this.tournamentService.TournamentListService(dataQuery)

} catch (err) {

}

}`

and this my class QueryObject

`export class QueryObject {
@IsString({ each: true })
@isarray()
@IsOptional()
filterBy?: string[]

@IsString({ each: true })
@isarray()
@IsOptional()
filter?: string[]

@IsString({ each: true })
@isarray()
@IsOptional()
searchBy?: string[]

@IsString()
@IsOptional()
search?: string

@IsString()
@IsOptional()
sortBy?: string

@IsEnum(ESorter)
@IsOptional()
sort: Sorter

@IsNumber()
@IsOptional()
page: number

@IsNumber()
@IsOptional()
perPage: number

@IsString({ each: true })
@isarray()
@IsOptional()
selectField?: string[]

@isboolean()
@IsOptional()
TransformDateTime: boolean
}`

When I send request to server have error
{ "statusCode": 400, "message": [ "filterBy must be an array", "filter must be an array", "searchBy must be an array" ], "error": "Bad Request" }

And If I remove @IsArray() result log is "id" should ["id"].

How I can validation is code. Thanks support.

Minimum reproduction code

https://github.com/Jeniphan

Steps to reproduce

No response

Expected behavior

And If I remove @IsArray() result log is "id" should ["id"].

Package version

^0.14.0

NestJS version

No response

Node.js version

^9.0.0

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

Snyk security scan reports that nestjs/class-validator has medium vulnerability related to dependency out-of-date.
The medium vulnerability related to dependency out-of-date can be fixed easily by upgrading the validation dependency to 13.7.0 version.

Minimum reproduction code

https://snyk.io/vuln/npm%3Avalidator

Steps to reproduce

No response

Expected behavior

Library should not have security vulnerabilities.

Package version

0.13.3

NestJS version

No response

Node.js version

No response

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): replace dependency rollup-plugin-terser with @rollup/plugin-terser ^0.1.0
• fix(deps): update dependency libphonenumber-js to v1.10.60
• chore(deps): update dependency @rollup/plugin-node-resolve to v15.2.3
• chore(deps): update dependency @types/node to v18.19.31
• chore(deps): update dependency eslint to v8.57.0
• chore(deps): update dependency eslint-config-prettier to v8.10.0
• chore(deps): update dependency lint-staged to v13.3.0
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-node action to v4
• chore(deps): update dependency @types/node to v20
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency eslint-config-prettier to v9
• chore(deps): update dependency eslint-plugin-jest to v28
• chore(deps): update dependency husky to v9
• chore(deps): update dependency lint-staged to v15
• chore(deps): update dependency prettier to v3
• chore(deps): update dependency rollup to v4
• chore(deps): update dessant/lock-threads action to v5
• chore(deps): update github/codeql-action action to v3
• chore(deps): update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency ts-jest to v29.1.2
• chore(deps): update dependency ts-node to v10.9.2
• chore(deps): update jest monorepo (@types/jest, jest)
• chore(deps): update dependency eslint-plugin-jest to v27.9.0
• chore(deps): update dependency reflect-metadata to v0.2.2
• chore(deps): update typescript-eslint monorepo to v5.62.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• fix(deps): update dependency validator to v13.11.0 (validator, @types/validator)
• chore(deps): update dependency @rollup/plugin-commonjs to v25
• chore(deps): update dependency rimraf to v5
• chore(deps): update dependency typescript to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

../node_modules/.pnpm/@[email protected]/node_modules/@nestjs/class-validator/types/decorator/string/IsPhoneNumber.d.ts:2:29 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("libphonenumber-js")' call instead.

2 import { CountryCode } from 'libphonenumber-js';
                               ~~~~~~~~~~~~~~~~~~~

../node_modules/.pnpm/[email protected]/node_modules/libphonenumber-js/index.d.ts:18:8 - error TS2834: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.

18 } from './types';
          ~~~~~~~~~

Minimum reproduction code

no

Steps to reproduce

No response

Expected behavior

no error message

Package version

0.13.4

NestJS version

9.3.9

Node.js version

20.1.8

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

upstream also suffers from that: typestack#1947 (comment)

Is there an existing issue that is already proposing this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe it

Creating a shim file with a reduced size for the browser would be a nice to have.

Describe the solution you'd like

Create a shim file for each decorator, using the same approach as @nestjs/swagger package.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

I would like to reuse dtos files between frontend and backend projects. Opening issue before creating a PR to check if it would be a good idea.

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

Running npm run audit throws a critical severity vulnerability on this package.

GHSA-fj58-h2fr-3pp2

Minimum reproduction code

GHSA-fj58-h2fr-3pp2

Steps to reproduce

1. Install @nestjs/mapped-types
2. Run npm audit

Expected behavior

There should be no critical vulnerabilities

Package version

0.13.1

NestJS version

8.0.0

Node.js version

18.12.1

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: Invalid configuration option: includeForks