GithubHelp home page GithubHelp logo

Comments (7)

prateekkathal avatar prateekkathal commented on May 2, 2024 2

I think I'll be able to get my hands on this today itself. Will create a PR soon.

from config.

kamilmysliwiec avatar kamilmysliwiec commented on May 2, 2024

We can add this feature under a flag (when enabled). Would you like to create a PR?

from config.

msheakoski avatar msheakoski commented on May 2, 2024

I will not have much time in the next 2 weeks to work on it, but I would be glad to submit a PR when I have availability if nobody else gets to it first.

from config.

prateekkathal avatar prateekkathal commented on May 2, 2024

@kamilmysliwiec I was working on this and just ran npm run test:integration and it seems all tests are failing due to some changes made in @hapi/joi (v17)

image

This is the line that is causing the failure.

Not sure how CircleCI tests are running fine.

from config.

kamilmysliwiec avatar kamilmysliwiec commented on May 2, 2024

@prateekkathal it looks like a Joi issue - hapijs/joi#2271 (nothing we can solve on our side)

from config.

prateekkathal avatar prateekkathal commented on May 2, 2024

@kamilmysliwiec As per hapijs/joi#2266, it looks like we'll have to change the documentation and ask them to run on Node v12.

Do you think we should update the hapijs/joi version for this package because of that though?

Let me know your thoughts. I'll update my node version and make a PR for this and update the documentation on nestjs/docs.nestjs.com.

from config.

kamilmysliwiec avatar kamilmysliwiec commented on May 2, 2024

Added in 0.1.0. Thank you @prateekkathal!

from config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.