GithubHelp home page GithubHelp logo

Comments (3)

kamilmysliwiec avatar kamilmysliwiec commented on April 25, 2024 1

ValidationSchema is not intended to validate partial configurations #209 (comment)

You can put the validation logic directly in the factory.

from config.

vtgn avatar vtgn commented on April 25, 2024

Hi!

I would like to reopen this issue because I got exactly the same problem.
Indeed, my "validate" function failed to validate the object built by the function given in the "load" field. By adding several console.log, I noticed the function given in the "load" field was called after the starting of the nest application, and so after the calling of the validate function.
I don't understand either why the files given in the "envFilePath" field are loaded before the calling of the "validate" method, and not the objects given in the "load" field.
This is totally illogical! And besides, the documentation says absolutely nothing on this subject.

When @kamilmysliwiec answered we can put the validation logic directly in the factory, we can also do the same with the files given in the "envFilePath", or with the environment variables of the system! This answer is just a nonsense, exactly the same way the "load" feature is implemented. Plus we must do two validations of the contents of ConfigService: absurd!
In that way, we don't need to use the ConfigModule and just manage our custom config object by ourselves. -_-°...

An API is made to facilitate the developers work, not to implement strange features that are completely illogical in certain cases with the goal of this API. The lack of information about this in the documentation and the several developers which don't understand why it doesn't work as expected prove the implementation of the "load" feature is illogical.

Regards.

from config.

kamilmysliwiec avatar kamilmysliwiec commented on April 25, 2024

Please search through some of our old issues on this (this has been discussed several times in the past).

from config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.