Comments (8)
@kamilmysliwiec I'm struggling to get automatic return types to function. Could it have been possible that the lack of return type inference is related to #956?
Would love to drop the constant { infer: true }
on every call if possible.
from config.
Makes total sense. Let me mark this issue as blocked for now. We'll wait till TS +4.1 is released
from config.
You can use [email protected]
in the PR. We'll wait some time to make sure it's stable and then, publish a new major version of the package (to avoid introducing breaking changes in minor/patch releases).
from config.
Would you like to create a PR for this feature?
from config.
Hey @kamilmysliwiec, I was looking at the implementation in the repo and I realized that it's possible to pass a dot-path, if you're loading config from a custom provider and not just process.env
.
Typing dot-paths will be possible in TS +4.1 with this PR:
type PropType<T, Path extends string> =
string extends Path ? unknown :
Path extends keyof T ? T[Path] :
Path extends `${infer K}.${infer R}` ? K extends keyof T ? PropType<T[K], R> : unknown :
unknown;
declare function getPropValue<T, P extends string>(obj: T, path: P): PropType<T, P>;
declare const s: string;
const obj = { a: { b: {c: 42, d: 'hello' }}};
getPropValue(obj, 'a'); // { b: {c: number, d: string } }
getPropValue(obj, 'a.b'); // {c: number, d: string }
getPropValue(obj, 'a.b.d'); // string
getPropValue(obj, 'a.b.x'); // unknown
getPropValue(obj, s); // unknown
But currently, I think the limitations of TS are that the types for nested access can only be inferred if the argument is either an array or multiple variables, IE:
get(obj, ['user', 'email'])
get(obj, 'user', 'email')
So this might have to wait a bit unfortunately =/
from config.
@GavinRay97 TS4 is already available. Would you like to take a look at this?
from config.
Yeah I believe it should be possible to implement this now, due to:
https://devblogs.microsoft.com/typescript/announcing-typescript-4-1-beta/
I think the only requirement would be to set TS version to 4.1-beta
and then later 4.1
in package.json
to ensure the type doesn't break for other people, right?
from config.
Let's track this here #492
from config.
Related Issues (20)
- Can't use envFilePath HOT 6
- Using optional environment variables leads to 'undefined' string value and incorrectly inferred type HOT 11
- Loaded config not validated HOT 4
- Update Type For "propertyPath" params in ConfigService.get HOT 1
- Allow nested properties be overridden by environment variables HOT 1
- Broken HTTP headers after upgrading from 2.3.2 to 2.3.3 HOT 1
- ConfigModule with validationSchema does not allow numbers HOT 6
- Class based configuration using decorators like @Configuration, @ConfigurationKey HOT 3
- Readonly ConfigType HOT 2
- Optional Registration using the ConfigModule HOT 9
- Eager loading of dotenv/.env HOT 4
- Support alternate parsers
- expandVariables option does not working correctly. HOT 1
- The function 'get' with default value and infer=true still returns undefined HOT 1
- Handle JS runtimes .env autoloading HOT 2
- Non-Reactive Behavior of NestJS ConfigService with Dynamic Environment Variable Updates HOT 3
- Validation is not performed on config loaded with custom loader HOT 2
- Feature to disable all configurations merge one object HOT 1
- ConfigType injection fails when used in a Module factory method. HOT 1
- ConditionalModule registerWhen support ConfigModule value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from config.