Comments (3)
you obviously just get the value as a string. But when providing a "generic" type
This "generic" type is wiped out after the compilation. The following line of code:
config.get<number>("PORT");
will be eventually transpiled to a vanilla JavaScript:
config.get("PORT");
Hence, we can't inter what type you expect at runtime.
At this stage, I'd say it'd be nice to have an option added to the get() function, say something like below which would cast to a number before returning.
@prateekkathal you should use custom configuration files for this
from config.
@matthiashermsen Thanks for the request.
I feel this is something subjective to the use case. Typescript is still evolving and sometimes, some declarations will state you to use a string PORT value than a number.
Also, the generics are meant for the purpose of declaration and not definition. At this stage, I'd say it'd be nice to have an option added to the get()
function, say something like below which would cast to a number before returning.
.get("PORT", { castTo: "number" })
However, I'd leave the final decision on @kamilmysliwiec.
Thanks again!
from config.
Thanks to your reply :) I think you are right. But I was expecting something like this:
When calling
config.get("PORT");
you obviously just get the value as a string. But when providing a "generic" type
config.get<number>("PORT");
then you explicitly want to cast the value before returning it. But yeah, this is just a suggestion and my personal opinion :)
from config.
Related Issues (20)
- Can't use envFilePath HOT 6
- Using optional environment variables leads to 'undefined' string value and incorrectly inferred type HOT 11
- Loaded config not validated HOT 4
- Update Type For "propertyPath" params in ConfigService.get HOT 1
- Allow nested properties be overridden by environment variables HOT 1
- Broken HTTP headers after upgrading from 2.3.2 to 2.3.3 HOT 1
- ConfigModule with validationSchema does not allow numbers HOT 6
- Class based configuration using decorators like @Configuration, @ConfigurationKey HOT 3
- Readonly ConfigType HOT 2
- Optional Registration using the ConfigModule HOT 9
- Eager loading of dotenv/.env HOT 4
- Support alternate parsers
- expandVariables option does not working correctly. HOT 1
- The function 'get' with default value and infer=true still returns undefined HOT 1
- Handle JS runtimes .env autoloading HOT 2
- Non-Reactive Behavior of NestJS ConfigService with Dynamic Environment Variable Updates HOT 3
- Validation is not performed on config loaded with custom loader HOT 2
- Feature to disable all configurations merge one object HOT 1
- ConfigType injection fails when used in a Module factory method. HOT 1
- ConditionalModule registerWhen support ConfigModule value HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from config.