Comments (1)
Well, so this one is somewhat tricky. ConfigModule
is one of these modules which actually introduces side-effects immediately after calling the forRoot()
method (as you've noticed) and this is actually, sort of the expected behavior. Basically, forRoot()
triggers loading the environment variables from .env
files using dotenv
package (and process.env
which holds env vars isn't scoped to any specific application, it's global for a Node process). This must happen right away (we could theoretically delay it a bit but I'm not sure whether that would be valuable) because these vars are typically crucial for other modules (and so they must be present before any provider is initialized - for example, we can't put this logic in the ConfigModule
class constructor because that would mean, in some cases, env vars could have been loaded after some other providers are already initialized).
What we could do here (to somehow address this issue), instead of triggering this logic right away inside the forRoot()
method, we could add a new hook (at the @nestjs/core
package level). This hook would be executed when module is indeed imported by any other module but before any of them is "processed". However, this would require changes in the core (as I've mentioned earlier) and would be useful only for this particular library (config package), which doesn't sound perfect.
from config.
Related Issues (20)
- Using optional environment variables leads to 'undefined' string value and incorrectly inferred type HOT 11
- Loaded config not validated HOT 4
- Update Type For "propertyPath" params in ConfigService.get HOT 1
- Allow nested properties be overridden by environment variables HOT 1
- Broken HTTP headers after upgrading from 2.3.2 to 2.3.3 HOT 1
- ConfigModule with validationSchema does not allow numbers HOT 6
- Class based configuration using decorators like @Configuration, @ConfigurationKey HOT 3
- Readonly ConfigType HOT 2
- Optional Registration using the ConfigModule HOT 9
- Eager loading of dotenv/.env HOT 4
- Support alternate parsers
- expandVariables option does not working correctly. HOT 1
- The function 'get' with default value and infer=true still returns undefined HOT 1
- Handle JS runtimes .env autoloading HOT 2
- Non-Reactive Behavior of NestJS ConfigService with Dynamic Environment Variable Updates HOT 3
- Validation is not performed on config loaded with custom loader HOT 2
- Feature to disable all configurations merge one object HOT 1
- ConfigType injection fails when used in a Module factory method. HOT 1
- ConditionalModule registerWhen support ConfigModule value HOT 1
- Add functionality to avoid support for .env files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from config.