Comments (5)
Hi,
how about changing ICommandHandler.execute
from
execute(command: T, resolve: (value?) => void);
to
execute(command: T): Promise<any>;
that way we'd have full information about whether command handling was successful or not,
and handlers wouldnt have to deal with that ugly-looking-callback-style resolve 😄
from cqrs.
Using CommandResult
would not make it possible to retry failed jobs though that are managed by some queue system. E.g. RabbitMQ. If a job failed, it'd go back to the queue and be retried again. This is a very useful pattern. But if all jobs always succeed, then this pattern is not possible.
from cqrs.
+1
from cqrs.
Hi,
The only way is to use resolve()
method. Something like CommandResult
sounds fine. 🙂
from cqrs.
@moltar I am looking exactly for the behaviour you mention: jobs managed by some queue system, such that in case the handler fails either caused by a (transient) exception, or the instance is shutdown, the job is retried automatically. Could you point me towards any resources/examples (anything really) on how to configure NestJS+Sagas in a manner to achieve exactly that?
from cqrs.
Related Issues (20)
- TypeError: You provided 'undefined' where a stream was expected HOT 2
- Middleware chain for command and querybud HOT 2
- Saga events - request context HOT 1
- documentation request HOT 1
- problems constructing instance with Mikro ORM HOT 1
- Feat: Register Commands, Queries & Events programatically HOT 1
- Multiple execution of events based on how many times module is imported HOT 1
- Adjust EventsHandler typing to accept the type of class extending IEvent
- Double events when using microservice HOT 2
- Sagas stop working in case of exceptions HOT 2
- Command handler becomes unresponsive HOT 4
- Event Handler fails to Trigger After Error Occurs HOT 1
- Use a decorator to automatically merge event publisher into AggregateRoot HOT 1
- Http Exceptions thrown in certain situations cause an app crash. HOT 1
- App crashes if event handler triggers a command that throws HOT 1
- CommandHandleException with Command Name not command uuid HOT 2
- Commit method throws an error when trying to publish domain events HOT 1
- Patch update reflect-metadata HOT 1
- Request scope or an alternative for multitenancy, using CQRS module
- Cannot read properties of undefined (reading 'id') - possible breaking change for 8.0.1 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cqrs.